Extension manager #284

splitbrain · 2013-08-11T09:46:49Z

This is the new extension manager as started by @michitux at the hackfest. I continued work on it and brought it to a state that's usable and mergable in my opinion. Note: this is a complete rewrite and just reuses the look'n'feel of Piyush's project.

Things that should be done before merging (preferable by people other than me):

code review. I might have done something stupid. especially security should be rechecked
real life tests. throw shit at it and see if it breaks
re-add RTL styles. I threw them out to keep things easy when reevaluate the needed CSS (sorry @selfthinker)
cross browser tests
remove the old plugin manager
whatever I forgot

…ry access

This uses a lot of code and the whole design from the previous extension manager implementation.

…to extension_manager * 'extension_manager' of github.com:splitbrain/dokuwiki: Extension manager: Implement extension table Extension manager: implement uninstall, canModify and install/update Extension manager: Improve update check Extension manager: Use getInfo() when no info.txt is available Extension manager: fix install dir for templates Extension manager: add language file and simple admin component Extension manager: implemented more extension info and basic repository access Extension manager: First draft of the extension class

this is not a extension specific cache but a global one. no need to purge for each installed extension

splitbrain · 2014-01-06T20:55:38Z

@selfthinker I can't reproduce it with Firefox and git installed plugins either. it's probably some interfering script from a different plugin.

selfthinker · 2014-01-06T23:53:16Z

Ah, I got it! In order to make it easier to fix HTML errors, I switched the template to be served as application/xhtml+xml and then forgot about it. That usually brings about some JS errors. After I switched back, the error disappeared. :)

And that tmp.innerHTML line is from jQuery, so the issue could still originate from the extension manager plugin (it most probably does, but only in XHTML).

dom-mel · 2014-01-08T17:26:16Z

lib/plugins/extension/helper/extension.php

+            }
+            $this->setExtension($this->getID());
+            $this->purgeCache();
+        }catch (Exception $e){


try/catch not needed

dom-mel · 2014-01-08T18:56:37Z

From just reading the source, the extension manager makes a very good impression :-)

I put all my comments in the source - but havn't test it ;-)

dom-mel · 2014-01-08T19:09:41Z

The dis-/en-abling of testing plugin feels wrong.

Reproduce 1:

Open the extension manager
Click on "enable" at the testing plugin
DokuWiki will show "plugin is enabled message", but the plugin:

The plugin still looks disabled
The plugin still has the enable button
The "testing plugin is enabled and should be disabled"-message is still not visible.

When you reload the page it's OK again. Disabling is the same behavior.

they were just catching and rethrowing

PHP_EOL is platform dependent, so you get in trouble while migrating between platforms.

dom-mel · 2014-01-08T19:28:02Z

The search has no "nothing found" text.
Additionally the search could be a little bit better. I.e. searching for PDF shows no plugin at all, but there are plenty of plugins with pdf in the title.

The filename found in the URL will be used for old plugins missing a base entry in their plugin.info.txt and lacking a subdirectory inside the archive as well. This patch makes sure possible query strings aren't included in the filename. Note: io_download() will also try to get a filename from any content-disposition header. If no filename can be found we simply use an md5 sum of the URL and hope the plugin will contain it's own hint for naming.

dom-mel · 2014-01-08T19:31:02Z

IMHO it would be nice to close the screenshot overlay with the esc key

dom-mel · 2014-01-08T19:44:15Z

maybe i can do some x-browser tests in the next days. (downloading the testing vms atm)

splitbrain · 2014-01-08T19:56:22Z

hey @dom-mel thanks a lot for your review.

I changed a few things already
The search not finding PDF was because MySQL's fulltext search requires 4 chars minimum by default. I reconfigured it on our server.
ESC for closing the lightbox would be nice, but I'm too tired to figure out how to do it right now (I'm using a very minimalistic aproach here, so we would need to code that ourselves)
I can't reproduce what you describe regarding the testing plugin. It enables and disables just fine and like all the other plugins.

dom-mel · 2014-01-11T10:48:45Z

Hi @splitbrain,
The thing i described seems to be fixed partly.
The only thing that's left can be reproduced by:

Enable testing plugin. - A Warning will be shown at the top.
Disable it again. - The warning is still present but the testing plugin is disabled. The warning goes away after the next page reload.

see:

splitbrain · 2014-01-11T11:07:31Z

I think we can live with that since the testing plugin is not part of the
regular release anyway

selfthinker · 2014-01-11T11:34:34Z

The testing plugin is part of the regular release.
But I think we can live with it anyway, as it is disabled by default.

splitbrain · 2014-01-11T16:05:42Z

really? it shouldn't. it makes no sense without the test suite.

michitux and others added 30 commits August 1, 2013 11:36

Extension manager: First draft of the extension class

c7b9800

Extension manager: implemented more extension info and basic reposito…

b9ca398

…ry access

Merge branch 'master' into extension_manager

366f1b4

Extension manager: add language file and simple admin component

788f86d

Extension manager: fix install dir for templates

9c0a726

Extension manager: Use getInfo() when no info.txt is available

7c30f5c

Extension manager: Improve update check

449f398

Extension manager: implement uninstall, canModify and install/update

1981046

Extension manager: Implement extension table

02779b1

This uses a lot of code and the whole design from the previous extension manager implementation.

added tabURL builder

dfabb22

fixed screenshot height

b8d600e

fixed typo in define

1414077

added connectivity recheck

e45b5c1

various gui fixes

a8332b6

added tab navigation

d741064

moved display stuff to gui class, added template list

5d7f316

added intros

1dd40c8

removed test repository again

a218edf

translated error message

7944abd

added gravatar images

e8dda2c

some initial go at the search tab

5533215

fixed some confusion between base, id and name

813d7e0

added a first unit test

89275cf

added 4th tab for manual install

ea9f3f9

moved CSS to LESS file, removed angua compatibility

2d87f05

added a very simplistic lightbox

61746d5

added tests for the find_folders method

519895b

installation now works

5c0b30b

make sure temporary folders are cleaned up

045d571

splitbrain added 2 commits January 6, 2014 21:29

purge cache only once on install

189c9ca

this is not a extension specific cache but a global one. no need to purge for each installed extension

typo fix

cf37525

dom-mel reviewed Jan 8, 2014
View reviewed changes

splitbrain added 2 commits January 8, 2014 20:18

remove unneeded try/catch blocks

ec8911d

they were just catching and rethrowing

use DOKU_LF

4bad83d

PHP_EOL is platform dependent, so you get in trouble while migrating between platforms.

splitbrain added 2 commits January 8, 2014 20:28

added missing localization

c837868

show a message when search returns no results

b1e7580

splitbrain merged commit b1e7580 into master Jan 19, 2014

splitbrain deleted the extension_manager branch January 19, 2014 19:13

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Extension manager #284

Extension manager #284

Uh oh!

splitbrain commented Aug 11, 2013

Uh oh!

splitbrain commented Jan 6, 2014

Uh oh!

selfthinker commented Jan 6, 2014

Uh oh!

dom-mel Jan 8, 2014

Uh oh!

dom-mel commented Jan 8, 2014

Uh oh!

dom-mel commented Jan 8, 2014

Uh oh!

dom-mel commented Jan 8, 2014

Uh oh!

dom-mel commented Jan 8, 2014

Uh oh!

dom-mel commented Jan 8, 2014

Uh oh!

splitbrain commented Jan 8, 2014

Uh oh!

dom-mel commented Jan 11, 2014

Uh oh!

splitbrain commented Jan 11, 2014

Uh oh!

selfthinker commented Jan 11, 2014

Uh oh!

splitbrain commented Jan 11, 2014

Uh oh!

Uh oh!

Uh oh!

Extension manager #284

Extension manager #284

Uh oh!

Conversation

splitbrain commented Aug 11, 2013

Uh oh!

splitbrain commented Jan 6, 2014

Uh oh!

selfthinker commented Jan 6, 2014

Uh oh!

dom-mel Jan 8, 2014

Choose a reason for hiding this comment

Uh oh!

dom-mel commented Jan 8, 2014

Uh oh!

dom-mel commented Jan 8, 2014

Uh oh!

dom-mel commented Jan 8, 2014

Uh oh!

dom-mel commented Jan 8, 2014

Uh oh!

dom-mel commented Jan 8, 2014

Uh oh!

splitbrain commented Jan 8, 2014

Uh oh!

dom-mel commented Jan 11, 2014

Uh oh!

splitbrain commented Jan 11, 2014

Uh oh!

selfthinker commented Jan 11, 2014

Uh oh!

splitbrain commented Jan 11, 2014

Uh oh!

Uh oh!