Renderer graceful fallback #571
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Now makes use of autoloader and can be claimed to resolve FS#2272 |
| $rclass = "Doku_Renderer_$mode"; | ||
| if ( class_exists($rclass) ) { | ||
| // viewers should see renderered output, so restrict the warning to admins only | ||
| $msg = "No renderer '$rname' found for mode '$mode', check your plugins"; |
There was a problem hiding this comment.
doesn't this duplicate the message in line 646?
There was a problem hiding this comment.
Actually, no, its the line 646 message that is redundant. 654 and 669 messages can both be output individually, but 646 will always be followed by one or other. I'll remove it.
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves FS#1767
After implementing this, I wonder if fallback should only be applied when $mode == 'xhtml'. The problem it solves is a replacement renderer plugin being disabled/uninstalled when it is the configured xhtml renderer and effectively all but disabling the wiki.