feat: add ProcessImpressionNoOp to ignore impressions entirely #474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @ryaneorth , We cannot fully ignore usage metrics and unique keys since they are currently an important part of our business logic. Setting the impressions mode to None, is as low as we can go with outgoing traffic. Having said that, I’ll make sure this is tracked as a feature request. Meanwhile we released 4.11.1 which includes a revamp of None mode logic. Thanks, |
|
Great, thank you Matias! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows for bypassing impression tracking, solving the problem reported in #473