fix: ADDON-65405 multi level menu #406
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artemrys
force-pushed
the
feat/multi-level-menu
branch
from
ce87891 to
74e9f31
Compare
vtsvetkov-splunk
changed the title
vtsvetkov-splunk
requested changes
Nov 10, 2023
| self.add_input.click() | ||
| popoverid = "#" + self.add_input.get_attribute("data-test-popover-id") | ||
| dropdown_selector = ( | ||
| ' [data-test="item"]:not([data-test-selected="true"]) [data-test="label"]' |
There was a problem hiding this comment.
can't you just get text from [data-test="item"]?
There was a problem hiding this comment.
I reused existing code part - :not([data-test-selected="true"] must have been added to not allow choosing already chosen option but I don't see a reason for such behaviour. Updated code as per your suggestion for both select() andselect_nested methods.
There was a problem hiding this comment.
if it is a menu, how it can be selected?
vtsvetkov-splunk
previously approved these changes
Nov 10, 2023
vtsvetkov-splunk
previously approved these changes
Nov 10, 2023
mkolasinski-splunk
force-pushed
the
feat/multi-level-menu
branch
from
42862b4 to
cfd0073
Compare
|
🎉 This PR is included in version 2.5.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces
select_nested()method indropdowncomponent which enables user to operate multi-level menu for inputs by providing to method sequence of buttons that are going to be clicked in given a order.sleep() function used within
select_nested()function to avoid issue with broken pop-up animation.