-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow developers to choose the default view #1197
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but wouldn't it be better to introduce a text parameter, where one could put a name of the default view? In case someone in the future asks for e.g. inputs being default?
67cc403
to
adb70a7
Compare
I am working on that right now. |
@artemrys are we alright? |
we are not, so all-checks did not prevent us from merging this because I do not remember using admin powers will work on a fix shortly |
Issue number: #1041
Summary
Changes
Configuration page require admin privileges and if a Splunk user is not an admin - configuration page will show an error which is confusing. This PR allows to set a default page to
search
so there will be no error shown when a Splunk user opens add-on for the first time.This PR enables TA developers to choose the default view, one of four:
inputs
,configuration
,dashboard
andsearch
.User experience
Nothing changes for the existing customers. For customers who decide to use
search
view as a default one - they need to update their globalConfig file, specifically setmeta.defaultView
tosearch
and rebuild an add-on.Checklist
If your change doesn't seem to apply, please leave them unchecked.