Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: basic UI dashboard page tests #1224

Merged
merged 13 commits into from
Jun 21, 2024

Conversation

soleksy-splunk
Copy link
Contributor

@soleksy-splunk soleksy-splunk commented Jun 4, 2024

Issue number: ADDON-70914

Summary

Basic tests for dashboard page.

Changes

Tests checking if dashboard page was rendered and some basic inputs and elements are displayed correctly.

User experience

More stable dashboard page

Checklist

If your change doesn't seem to apply, please leave them unchecked.

@soleksy-splunk soleksy-splunk marked this pull request as ready for review June 5, 2024 09:36
@soleksy-splunk soleksy-splunk requested a review from a team as a code owner June 5, 2024 09:36
ui/src/pages/Dashboard/tests/DashBoardPage.test.tsx Outdated Show resolved Hide resolved
ui/src/pages/Dashboard/tests/DashBoardPage.test.tsx Outdated Show resolved Hide resolved
ui/src/pages/Dashboard/tests/mockJs.ts Outdated Show resolved Hide resolved
ui/src/pages/Dashboard/tests/DashBoardPage.test.tsx Outdated Show resolved Hide resolved
ui/src/pages/Dashboard/tests/DashBoardPage.test.tsx Outdated Show resolved Hide resolved
Copy link
Contributor

@vtsvetkov-splunk vtsvetkov-splunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments have not been addressed

@soleksy-splunk
Copy link
Contributor Author

Comments have not been addressed

sorry, i made changes yesterday but did not push them ...

@artemrys
Copy link
Member

Unit tests for UI are failing.

@soleksy-splunk soleksy-splunk force-pushed the test/basic-ui-dashboard-page-tests branch from d5d188f to 3f71547 Compare June 21, 2024 14:00
@soleksy-splunk soleksy-splunk marked this pull request as ready for review June 21, 2024 15:13
@soleksy-splunk soleksy-splunk merged commit e9cb033 into develop Jun 21, 2024
45 of 46 checks passed
@soleksy-splunk soleksy-splunk deleted the test/basic-ui-dashboard-page-tests branch June 21, 2024 15:37
@github-actions github-actions bot locked and limited conversation to collaborators Jun 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants