-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: basic UI dashboard page tests #1224
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtsvetkov-splunk
requested changes
Jun 6, 2024
vtsvetkov-splunk
requested changes
Jun 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comments have not been addressed
sorry, i made changes yesterday but did not push them ... |
vtsvetkov-splunk
previously approved these changes
Jun 19, 2024
Unit tests for UI are failing. |
soleksy-splunk
force-pushed
the
test/basic-ui-dashboard-page-tests
branch
from
June 21, 2024 14:00
d5d188f
to
3f71547
Compare
vtsvetkov-splunk
approved these changes
Jun 21, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: ADDON-70914
Summary
Basic tests for dashboard page.
Changes
Tests checking if dashboard page was rendered and some basic inputs and elements are displayed correctly.
User experience
More stable dashboard page
Checklist
If your change doesn't seem to apply, please leave them unchecked.