Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Branch Updates #1

Merged
merged 3 commits into from
May 6, 2019
Merged

Branch Updates #1

merged 3 commits into from
May 6, 2019

Conversation

josehelps
Copy link
Contributor

@russnolen prepared the branch into github, its missing CI only that is going to take me a bit longer but for now wanted you to review the changes before we close down the bitbucket repo. This already has:

  • branch protection
  • automation with assigning reviewers, closing stale pulls, and deleting merged branches
  • slack configured under the dev bot
  • pre-commit hooks to automatically validate for commit errors
  • updated requirements.txt with pre-commit hook dep
  • a handful of README updates

Obligatory cool logo ;-)

philroyer-phantom
philroyer-phantom reviewed May 6, 2019
View reviewed changes
Copy link
Contributor

@philroyer-phantom philroyer-phantom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Asked for a few clarifications, but feel free to disregard

README.md Outdated Show resolved Hide resolved
requirements.txt Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
@josehelps
Update README.md
0af2bee 
made the instructions a bit more accurate
philroyer-phantom
philroyer-phantom approved these changes May 6, 2019
View reviewed changes
Copy link
Contributor

@philroyer-phantom philroyer-phantom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@russnolen russnolen merged commit c292444 into master May 6, 2019
@sescandor sescandor mentioned this pull request Jan 20, 2020
Closed
@jxsmith786110 jxsmith786110 mentioned this pull request Dec 25, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@russnolen russnolen russnolen approved these changes

@philroyer-phantom philroyer-phantom philroyer-phantom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@josehelps @russnolen @philroyer-phantom