Remove sudo #72
Merged
Remove sudo #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nwang92
reviewed
Dec 6, 2018
| @@ -46,7 +46,7 @@ ln -s busybox syslogd | |||
| ln -s busybox tail | |||
| ln -s busybox traceroute | |||
| ln -s busybox vi | |||
|
|
|||
| chmod u+s /bin/ping | |||
There was a problem hiding this comment.
May need to do this for ping6 as well - the other symlinks we created don't seem to be affected by this permission issue
There was a problem hiding this comment.
this is needed to create an icmp packet, ping6 doesn't actually use icmp in the same way. I did test it, and ran through a few of the other commands. I didn't see any others that failed.
arctan5x
previously approved these changes
Dec 6, 2018
bb03
previously approved these changes
Dec 6, 2018
nwang92
previously approved these changes
Dec 7, 2018
bb03
approved these changes
Dec 7, 2018
jmeixensperger
approved these changes
Dec 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This requires a timed merge with splunk-ansible.