Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation links and formatting #834

Closed
jaydeluca opened this issue May 12, 2024 · 2 comments · Fixed by #836
Closed

Documentation links and formatting #834

jaydeluca opened this issue May 12, 2024 · 2 comments · Fixed by #836
Assignees
Labels

Comments

@jaydeluca
Copy link

jaydeluca commented May 12, 2024

While reading the documentation, I have been encountering what looks like what might be broken links or references, where there is a {ref} followed by what looks like should be a hyperlink of some sort

Example:

The conf file should follow the specifications as mentioned {ref}`here <conf_spec`.

Examples in code base:

When rendered on the doc site they look like:

image image image

Should these be linking to something or formatting differently?

Also, anywhere there is an example cli argument, there is usually a placeholder explaining what the value should be, but they are all missing a closing >.

Example:

pytest --splunk-type=external --splunk-app=<path-to-addon-package --splunk-data-generator=<path to pytest-splunk-addon-data.conf file --splunk-host=<hostname --splunk-port=<splunk-management-port --splunk-user=<username --splunk-password=<password --splunk-hec-token=<splunk_hec_token

Should these instead be closed like below or is this intentional?

pytest --splunk-type=external --splunk-app=<path-to-addon-package> --splunk-data-generator=<path to pytest-splunk-addon-data.conf file> --splunk-host=<hostname> --splunk-port=<splunk-management-port> --splunk-user=<username> --splunk-password=<password> --splunk-hec-token=<splunk_hec_token>
@artemrys
Copy link
Member

@jaydeluca thanks for raising the ticket, we just recently migrated documentation to GitHub Pages and something might look wrong

we will work on the necessary fixes

harshilgajera-crest added a commit that referenced this issue May 14, 2024
- Updated the md files for proper reference.
- Added missing brackets

Fixes #834
@srv-rr-github-token
Copy link
Contributor

🎉 This issue has been resolved in version 5.2.6 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants