-
Notifications
You must be signed in to change notification settings - Fork 3
Conversation
…r-snmp-poller into feat/async_rework
…r-snmp-poller into feat/async_rework � Conflicts: � poetry.lock
TRANSLATION_URL, headers=headers, data=payload, params=params, timeout=60 | ||
) | ||
|
||
async with ClientSession() as session: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do we need
async with ClientSession() as session if in trap we do the same with just session = ClientSession?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is Python equivalent of autoclosable feature. I missed it in trap. I'll add it now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and same question as in trap, was removal of the retries a wanted change in logic?
…r-snmp-poller into feat/async_rework � Conflicts: � splunk_connect_for_snmp_poller/manager/tasks.py
Codecov Report
@@ Coverage Diff @@
## develop #122 +/- ##
===========================================
+ Coverage 59.53% 59.91% +0.37%
===========================================
Files 33 33
Lines 1389 1387 -2
===========================================
+ Hits 827 831 +4
+ Misses 562 556 -6
Continue to review full report at Codecov.
|
Expected release notes (by @weliasz) features: fixes: others (will not be included in Semantic-Release notes):
|
🎉 This PR is included in version 1.5.0-develop.8 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
No description provided.