Skip to content
This repository has been archived by the owner on Dec 17, 2021. It is now read-only.

Feat/async rework #122

Merged
merged 24 commits into from
Sep 21, 2021
Merged

Feat/async rework #122

merged 24 commits into from
Sep 21, 2021

Conversation

weliasz
Copy link
Contributor

@weliasz weliasz commented Sep 15, 2021

No description provided.

TRANSLATION_URL, headers=headers, data=payload, params=params, timeout=60
)

async with ClientSession() as session:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we need
async with ClientSession() as session if in trap we do the same with just session = ClientSession?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is Python equivalent of autoclosable feature. I missed it in trap. I'll add it now.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and same question as in trap, was removal of the retries a wanted change in logic?

…r-snmp-poller into feat/async_rework

� Conflicts:
�	splunk_connect_for_snmp_poller/manager/tasks.py
@codecov-commenter
Copy link

codecov-commenter commented Sep 16, 2021

Codecov Report

Merging #122 (2b9a731) into develop (a003fbd) will increase coverage by 0.37%.
The diff coverage is 38.88%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #122      +/-   ##
===========================================
+ Coverage    59.53%   59.91%   +0.37%     
===========================================
  Files           33       33              
  Lines         1389     1387       -2     
===========================================
+ Hits           827      831       +4     
+ Misses         562      556       -6     
Impacted Files Coverage Δ
splunk_connect_for_snmp_poller/manager/tasks.py 38.15% <27.27%> (+1.17%) ⬆️
...nnect_for_snmp_poller/manager/mib_server_client.py 39.39% <42.85%> (+10.44%) ⬆️
..._connect_for_snmp_poller/manager/task_utilities.py 22.48% <45.45%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a003fbd...2b9a731. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 20, 2021

Expected release notes (by @weliasz)

features:
update of lock file (4068e1e)
added retry logic (1fd8ef8)
introduction of asynchronous communication with MIB server (fc1938d)
enrich data with linked tables (#101) (75bdb13)
extract enricher data from config (#97) (123864f)
extract IF-MIB data from an SNMPWALK (#96) (7699591)
support polling the same IP address using multiple profiles (#92) (a6320ca)

fixes:
update lock (2b9a731)
dependencies (e57326c)
cleanup (5c724b6)
cleanup (8e16ccb)
cleanup (f76dbca)
cleanup (e9458ad)
cleanup (7a2cdf0)
conflict resolved (1c3730a)
conflict resolved (2cf9c64)
timeout and async loop (d0a2376)
debug (ee5e4db)
debug (39b5c7a)
debug (b51b84c)
debug (512f6ff)
async (23d6e13)
async (ea6e4f1)
async (a4df1d9)
dependencies (091c1ff)
update splunk indexes with meta_index (#116) (6d3f1bc)
changed indexes (#114) (9644663)
change way of checking if profile is an OID to use regex (#112) (277a050)
mongo real time data check (#107) (4526b0c)
change the way of creating host name which is an id in the database (#104) (bbf2733)
forced commit for creating new release (f3081c1)

others (will not be included in Semantic-Release notes):
disable shellcheck SC1090 (734d523)
add actionlint as pre-commit step (52ac6f8)
allow dependabot[bot] and remove custom allow policy (437745f)
pre-commit autoupdate [ci skip] (e0544a4)
7ef1a09 refactor
remove black from dev dependency (1b07dd8)
add pre-commit step and remove lint step (9ef6611)
update severity threshold for snyk to "high" (#113) (7540a5b)
pre-commit autoupdate [ci skip] (6ff7b00)
pre-commit and debug statements [ci skip] (bb5e0ff)
set threshold for jscdp linter (#105) (c01fb4d)
1.5.0-develop.3 (7306e5d)
fix of duplicated code linter problem (c855088)
fix shellcheck (2fa415a)
apply mypy and flake8 (ec32122)
apply pre-commit isort (9c906f9)
exclude json files from copyright check (f3d6b2d)
update README to include pre-commit (cd6a9eb)
apply pre-commit black (c53b8b6)
pre-commit (9a24536)
33acbbf feat: Replace multiple SNMP walks with one SNMP Bulk (#100)
ebe3ebf Feature/redo walk (#95)
d5879c5 Stubs for lint
9cff184 Stubs for lint
adddbea Stubs for lint
5dc1549 Stubs for lint
2c5a5c3 Feat/multiple profiles2 (#93)

  • I hereby acknowledge these release notes are 🥙 AWESOME 🥙

@weliasz weliasz merged commit 4dd2c28 into develop Sep 21, 2021
@weliasz weliasz deleted the feat/async_rework branch September 21, 2021 07:30
@github-actions github-actions bot locked and limited conversation to collaborators Sep 21, 2021
@ryanfaircloth
Copy link
Contributor

🎉 This PR is included in version 1.5.0-develop.8 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants