-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Providing options.privateKey means no password is required #19
Conversation
Previously, a password prompt showed up if you did not provide a password on options.password, whether or not you provided a privateKey. There should not be a password prompt if a password OR a privateKey is provided.
Providing options.privateKey means no password is required
It would be good if you can ignore |
Ugh. My bad, man. It was a new computer. Apologies. Another PR could remove it. |
Guys, any plans for a release with this modification? |
Would anyone want to maintain this project? |
I would be more than happy to maintain this project. It is currently a staple on my team. |
@dkurucz what's your npm account? |
Same as my github, dkurucz |
@dkurucz there is also a node-scp2 which is a dependency of grunt-scp, would u like to maintain it as well? |
Sure why not! -Doug On Fri, Dec 11, 2015 at 11:02 AM, Hsiaoming Yang notifications@github.com
|
Thanks for picking this up @dkurucz :) Now this is merged would it possible to do a release? Installs from npm at stuck on 0.1.8. |
No problem, I have a few enhancements I'm working on to enable better unit testing. Once that is in place (shouldn't be too much longer now), I'll increment the version and then start going through the pull requests. |
👍 awesome stuff, again, thank you! |
Trying to publish to 0.1.9, @lepture can you please add me to the npm repo? |
@dkurucz done |
Thanks! |
Previously, a password prompt showed up if you did not provide a password on options.password, whether or not you provided a privateKey. There should not be a password prompt if a password OR a privateKey is provided.