Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Providing options.privateKey means no password is required #19

Merged
merged 3 commits into from Dec 20, 2014
Merged

Providing options.privateKey means no password is required #19

merged 3 commits into from Dec 20, 2014

Conversation

morrissinger
Copy link
Contributor

Previously, a password prompt showed up if you did not provide a password on options.password, whether or not you provided a privateKey. There should not be a password prompt if a password OR a privateKey is provided.

Previously, a password prompt showed up if you did not provide a password on options.password,
whether or not you provided a privateKey. There should not be a password prompt if a password
OR a privateKey is provided.
@morrissinger morrissinger mentioned this pull request Dec 19, 2014
lepture added a commit that referenced this pull request Dec 20, 2014
Providing options.privateKey means no password is required
@lepture lepture merged commit be1b78e into spmjs:master Dec 20, 2014
@lenage
Copy link

lenage commented Apr 9, 2015

It would be good if you can ignore .idea files

@morrissinger
Copy link
Contributor Author

Ugh. My bad, man. It was a new computer. Apologies. Another PR could remove it.

@gfpacheco
Copy link

Guys, any plans for a release with this modification?

@lepture
Copy link
Contributor

lepture commented Aug 26, 2015

Would anyone want to maintain this project?

@dkurucz
Copy link
Collaborator

dkurucz commented Dec 10, 2015

I would be more than happy to maintain this project. It is currently a staple on my team.

@lepture
Copy link
Contributor

lepture commented Dec 11, 2015

@dkurucz what's your npm account?

@dkurucz
Copy link
Collaborator

dkurucz commented Dec 11, 2015

Same as my github, dkurucz

@lepture
Copy link
Contributor

lepture commented Dec 11, 2015

@dkurucz there is also a node-scp2 which is a dependency of grunt-scp, would u like to maintain it as well?

@dkurucz
Copy link
Collaborator

dkurucz commented Dec 11, 2015

Sure why not!

-Doug

On Fri, Dec 11, 2015 at 11:02 AM, Hsiaoming Yang notifications@github.com
wrote:

@dkurucz https://github.com/dkurucz there is also a node-scp2 which is
a dependency of grunt-scp, would u like to maintain it as well?


Reply to this email directly or view it on GitHub
#19 (comment).

@jwhitmarsh
Copy link

Thanks for picking this up @dkurucz :) Now this is merged would it possible to do a release? Installs from npm at stuck on 0.1.8.

@dkurucz
Copy link
Collaborator

dkurucz commented Feb 10, 2016

No problem, I have a few enhancements I'm working on to enable better unit testing. Once that is in place (shouldn't be too much longer now), I'll increment the version and then start going through the pull requests.

@jwhitmarsh
Copy link

👍 awesome stuff, again, thank you!

@dkurucz
Copy link
Collaborator

dkurucz commented Feb 29, 2016

Trying to publish to 0.1.9, @lepture can you please add me to the npm repo?

@lepture
Copy link
Contributor

lepture commented Mar 1, 2016

@dkurucz done

@dkurucz
Copy link
Collaborator

dkurucz commented Mar 1, 2016

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants