Add FAQ to documentation #1212
Merged
Add FAQ to documentation #1212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For now, there are two FAQ items explaining optional dependencies in general and explaining why there are two class mocking variants ByteBuddy vs. CGLIB. Closes spockframework#1165.
Codecov Report
@@ Coverage Diff @@
## master #1212 +/- ##
=========================================
Coverage 76.27% 76.27%
Complexity 3678 3678
=========================================
Files 396 396
Lines 11264 11264
Branches 1382 1382
=========================================
Hits 8592 8592
Misses 2193 2193
Partials 479 479 Continue to review full report at Codecov.
|
szpak
previously approved these changes
Sep 2, 2020
leonard84
requested changes
Sep 7, 2020
There was a problem hiding this comment.
It should also be mentioned, that spock will use ByteBuddy if both libraries are on the classpath.
Also please format according to one sentence per line, I know that not every part of the guide follows that guideline yet, but new documentation should.
Co-authored-by: Leonard Brünings <lord_damokles@gmx.net>
Co-authored-by: Leonard Brünings <lord_damokles@gmx.net>
Co-authored-by: Leonard Brünings <lord_damokles@gmx.net>
leonard84
approved these changes
Sep 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now, there are two FAQ items explaining optional dependencies in general and
explaining why there are two class mocking variants ByteBuddy vs. CGLIB.
Closes #1165.
This change is