Brew gem breakup #23
Brew gem breakup #23
Conversation
|
Holy shit this awesome!! I can do a more thorough review in a bit. |
| it { is_expected.to_not be_successfully_executed } | ||
| end | ||
|
|
||
| context "install/uninstall" do #, announce_stderr: true, announce_stdout: true do |
There was a problem hiding this comment.
is this comment for clarity or left over from a past attempt?
I'm not super familiar with aruba. I think I've used it once. It works great for this.
There was a problem hiding this comment.
Ah, it's actually a debug comment. If you delete do # then it changes to print stdout/stderr for the containing specs.
Related, I think I'm going to make that whole block an integration spec anyway so it can be exclude by Travis builds where brew isn't present.
|
Great Idea making this a gem. I think it makes it way easier to develop. I opened #24 to represent setting the sha in the download strategy great idea. |
|
Yeah, I wasn't sure if we actually want to release and distribute as a gem, but it might make sense to do so? |
|
we could. It for sure makes development of it way easier. Assuming it works the same as a gem as it does for homebrew I think it's fine. I wonder what would happen if you brew-gem brew-gem. |
|
Ok, I'm ready to merge. Let me know and I can cut the release and push to rubygems. I also have updates to the Homebrew/homebrew-core recipe in flight. |
nicksieger
force-pushed
the
brew-gem-breakup
branch
from
0594cef
to
9690c9c
Compare
|
|
Nice work!
Addresses issues in #16.
Also, the way the code is written now, it would be straightforward to add sha256 support using the Rubygems API to fetch gem information.