Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix updatedb for new games #48

Merged
merged 6 commits into from
Oct 20, 2021
Merged

Fix updatedb for new games #48

merged 6 commits into from
Oct 20, 2021

Conversation

mrcaseb
Copy link
Collaborator

@mrcaseb mrcaseb commented Oct 20, 2021

This PR fixes #35

Summary:

  • added option for db directory. That's a new feature in nflfastR that I implemented here also
  • fix for season rebuild when games are missing. The function tried to extract season from game_ids which is wrong for cfb game ids.

@mrcaseb mrcaseb mentioned this pull request Oct 20, 2021
Closed
@mrcaseb
The messages require cli >= 3.0.
6e62ad6 
Also dumped the qs version requirement as 0.25.1 includes an important fix
saiemgilani
saiemgilani approved these changes Oct 20, 2021
View reviewed changes
Copy link
Collaborator

@saiemgilani saiemgilani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thanks.

@saiemgilani saiemgilani merged commit 694ace4 into master Oct 20, 2021
@mrcaseb mrcaseb deleted the fix-updatedb-for-new-games branch October 20, 2021 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saiemgilani saiemgilani saiemgilani approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

update_cfb_db issue
2 participants
@mrcaseb @saiemgilani