added getWeeklySchedule(week, year, seasonType) to NFL service
#20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
unmonk
changed the title
getWeeklySchedule(week, year, seasonType)getWeeklySchedule(week, year, seasonType) to NFL service
|
Sounds good. And this is no problem, but whatever nfl schedule function was there could've also just accepted date=year and a week parameter. Merge as you want, make the version/changelog updates, then run the publish action |
|
Hmm that could be a possibility as well. I'm actually looking at doing a typescript fork soon, which I am hoping to overhaul how params are handled. How are you handling the version bump? I dont think I see it as part of the publish workflow. Looks like just a manual bump and commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My brother asked for a pickem league, the current nfl.getSchedule fetches by year, month, day. Which could work, but wasnt the easiest solution for me.
getWeeklySchedule(week, year, seasonType)is just utilizing some different params on that same cdnhttp://cdn.espn.com/core/nfl/schedule/_/week/${week}/year/${year}/seasontype/${seasonType}`;Defaults to 1st week of regular season, of current year, if no parameters are provided.
Related tests created.
Ran
md-nflandreadme