Skip song if track is empty. #1164
Conversation
ghost
mentioned this pull request
|
#1163 is for the same thing. Not sure which is better. Maybe have a look at that too. |
spotdl/search/utils.py
Outdated
| if song.get_youtube_link() != None: | ||
| playlistTracks.append(song) | ||
|
|
||
| # check if more tracks are to be passed | ||
| if playlistResponse['next']: | ||
| playlistResponse = spotifyClient.playlist_tracks( | ||
| playlistUrl, | ||
| offset = len(playlistTracks) | ||
| offset = playlistResponse['offset'] + playlistResponse['limit'] |
There was a problem hiding this comment.
This is not need necessary, is it?
There was a problem hiding this comment.
If a track is None, playlisttracks will not increase. So you will request duplicate entries
And if you have, in theory, 100 None entries. The offset will stay the same and the program will be stuck
So I would say it's essential
| @@ -79,17 +79,20 @@ def get_playlist_tracks(playlistUrl: str) -> List[SongObj]: | |||
| while True: | |||
|
|
|||
| for songEntry in playlistResponse['items']: | |||
| if songEntry['track'] is None: | |||
There was a problem hiding this comment.
I think we should check if the id is None because if the track is not None but the id is missing spotdl will crash
if songEntry['track']['id'] is None:
continue
There was a problem hiding this comment.
I think we'd need to check both of them. Because in #1147 the songEntry['track'] is None
There was a problem hiding this comment.
Is it possible to have a none None track, but with an empty id?
There was a problem hiding this comment.
I guess so. If the track would be empty we would get object is not subscriptable error, but in the screenshot above songEntry['track']['id'] returns None for some reason
There was a problem hiding this comment.
Looks like tracks with no id are tracks that are not available in your country/removed from spotify or something like that
|
@bee395 can you pull from |
bee395
force-pushed
the
skip-empty-track
branch
from
4525272
to
ad77fa2
Compare
bee395
force-pushed
the
skip-empty-track
branch
from
ad77fa2
to
c377d06
Compare
* Run regressions on CI (#1158) Authored by @aklajnert * Use argparse instead of raw `sys.argv` (#1157) Authored by @aklajnert * FIxed error caused by songs with ':' in name (#1162) Authored by @MikhailZex * Fixed TypeError when downloading tracks (#1177) Authored by @xnetcat * Bump version to 3.3.2 * Lint with flake8, fix code to pass it (#1178) Authored by @aklajnert * Fixed flake8 (#1181) Authored by @aklajnert * Skip song if track is empty. (#1164) Authored by @bee395 Co-authored-by: Andrzej Klajnert <github@aklajnert.pl> Co-authored-by: Michael George <MikhailZex@gmail.com> Co-authored-by: Jakub <42355410+xnetcat@users.noreply.github.com> Co-authored-by: bee395 <bee395@users.noreply.github.com>
Description
Some playlist requested with spotipy contain empty tracks.
This change will skip those tracks, and use the correct offset for the next request.
Types of changes