Lint with flake8, fix code to pass it #1178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Silverarmor
reviewed
Feb 6, 2021
There was a problem hiding this comment.
Should we add a note in CONTRIBUTING.md, getting devs to lint with flake8 before pushing changes?
I think we can add it later when we also add |
Silverarmor
approved these changes
Feb 6, 2021
Yes, it shouldn't be much work. Fixing the whole app took me around 30 minutes. |
Silverarmor
added a commit
that referenced
this pull request
Feb 7, 2021
This reverts commit 6bba464.
Silverarmor
reviewed
Feb 7, 2021
| @@ -1,5 +1,3 @@ | |||
| from .__main__ import console_entry_point | |||
Silverarmor
added a commit
that referenced
this pull request
Feb 8, 2021
* Run regressions on CI (#1158) Authored by @aklajnert * Use argparse instead of raw `sys.argv` (#1157) Authored by @aklajnert * FIxed error caused by songs with ':' in name (#1162) Authored by @MikhailZex * Fixed TypeError when downloading tracks (#1177) Authored by @xnetcat * Bump version to 3.3.2 * Lint with flake8, fix code to pass it (#1178) Authored by @aklajnert * Fixed flake8 (#1181) Authored by @aklajnert * Skip song if track is empty. (#1164) Authored by @bee395 Co-authored-by: Andrzej Klajnert <github@aklajnert.pl> Co-authored-by: Michael George <MikhailZex@gmail.com> Co-authored-by: Jakub <42355410+xnetcat@users.noreply.github.com> Co-authored-by: bee395 <bee395@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are no changes in functionality - mostly fixed formatting issues like line breaks, spacing etc.
This is the first stage of
flake8introduction, later I'll add some plugins to check for more.Additionally,
mypyis extracted to a separate job in CI.