Fixed TypeError when downloading tracks #1177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Silverarmor
added
Bug Fix
aklajnert
approved these changes
Feb 6, 2021
| @@ -95,7 +95,7 @@ def __map_result_to_song_data(result: dict) -> dict: | |||
| 'name': result['title'], | |||
| 'type': result['resultType'], | |||
| 'artist': artists, | |||
| 'length': __parse_duration(result['duration']), | |||
| 'length': __parse_duration(result.get('duration', None)), | |||
There was a problem hiding this comment.
The None is a default return value from get() function. You don't have to specify it.
Suggested change
| 'length': __parse_duration(result.get('duration', None)), | |
| 'length': __parse_duration(result.get('duration')), |
Silverarmor
approved these changes
Feb 6, 2021
There was a problem hiding this comment.
See interesting point:
https://discord.com/channels/771628785447337985/771628785891672086/807519313770577920
|
Hi @xnetcat! Great to see you contributing around spotDL! Thanks for this contribution! :) |
Merged
Silverarmor
added a commit
that referenced
this pull request
Feb 8, 2021
* Run regressions on CI (#1158) Authored by @aklajnert * Use argparse instead of raw `sys.argv` (#1157) Authored by @aklajnert * FIxed error caused by songs with ':' in name (#1162) Authored by @MikhailZex * Fixed TypeError when downloading tracks (#1177) Authored by @xnetcat * Bump version to 3.3.2 * Lint with flake8, fix code to pass it (#1178) Authored by @aklajnert * Fixed flake8 (#1181) Authored by @aklajnert * Skip song if track is empty. (#1164) Authored by @bee395 Co-authored-by: Andrzej Klajnert <github@aklajnert.pl> Co-authored-by: Michael George <MikhailZex@gmail.com> Co-authored-by: Jakub <42355410+xnetcat@users.noreply.github.com> Co-authored-by: bee395 <bee395@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
YMusic sometimes returns results without duration, this commit makes sure that it does not break spotdl
track: https://open.spotify.com/track/3pjUyVbFmM96tYhSaKJwTt?si=EL8F3YB4SZqfJGU267O4-g
Error:
