bugfix: replace rapidfuzz with thefuzz #1391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Silverarmor
approved these changes
Oct 6, 2021
Silverarmor
added a commit
to Silverarmor/spotify-downloader
that referenced
this pull request
Oct 23, 2021
thefuzz was giving a headache. Revert spotDL#1391 back to rapidfuzz.
10 tasks
xnetcat
pushed a commit
that referenced
this pull request
Oct 23, 2021
Silverarmor
added a commit
that referenced
this pull request
Oct 24, 2021
* bugfix: don't add cover if spotify does not provide album cover (#1384) * 🪶: Refactor Code Expression (#1390) Co-authored-by: Silverarmor <23619946+Silverarmor@users.noreply.github.com> Co-authored-by: Jakub Kot <42355410+xnetcat@users.noreply.github.com> Co-authored-by: Peyton Creery <44987569+phcreery@users.noreply.github.com> * bugfix: replace rapidfuzz with thefuzz (#1391) * gitignore update and update tests for multithread search (#1398) * misc improvements (#1392) This reverts commit 5787bea. Co-authored-by: Silverarmor <23619946+Silverarmor@users.noreply.github.com> * Multiple Lyrics Providers (#1397) Co-authored-by: Silverarmor <23619946+Silverarmor@users.noreply.github.com> Co-authored-by: Jakub Kot <xnetcat.dev@gmail.com> * misc: fix warnings (#1400) * revert bea748b: revert to rapidfuzz (#1403) * ci: cleanup (#1402) * feat: added path template (#1401) Co-authored-by: Silverarmor <23619946+Silverarmor@users.noreply.github.com> Co-authored-by: Jakub Kot <42355410+xnetcat@users.noreply.github.com> Co-authored-by: Yasser Tahiri <yasserth19@gmail.com> Co-authored-by: Peyton Creery <44987569+phcreery@users.noreply.github.com> Co-authored-by: Arbaaz Shafiq <arbaazshafiq@gmail.com> Co-authored-by: Jakub Kot <xnetcat.dev@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title
replace rapidfuzz with thefuzz
Description
replace rapidfuzz with thefuzz
Related Issue
Motivation and Context
rapdifuzz requires additional build dependencies on python 3.10
How Has This Been Tested?
pytest
Screenshots (if appropriate)
Types of Changes
Checklist