Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc: fix warnings #1400

Merged
merged 2 commits into from Oct 22, 2021
Merged

misc: fix warnings #1400

merged 2 commits into from Oct 22, 2021

Conversation

xnetcat
Copy link
Member

@xnetcat xnetcat commented Oct 22, 2021

Title

fix warnings

Description

fix some possibly unbound errors, and deprecated spotipy function warning

Related Issue

no

Motivation and Context

it's better now, trust me

How Has This Been Tested?

pytest

Screenshots (if appropriate)

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have read the CONTRIBUTING document
  • I have read the CORE VALUES document
  • I have added tests to cover my changes
  • All new and existing tests passed

@Silverarmor Silverarmor merged commit 209dfde into spotDL:dev Oct 22, 2021
@Silverarmor Silverarmor added the Bug Fix PRs that fix bugs label Oct 22, 2021
Silverarmor added a commit that referenced this pull request Oct 24, 2021
* bugfix: don't add cover if spotify does not provide album cover (#1384)


* 🪶: Refactor Code Expression (#1390)
Co-authored-by: Silverarmor <23619946+Silverarmor@users.noreply.github.com>
Co-authored-by: Jakub Kot <42355410+xnetcat@users.noreply.github.com>
Co-authored-by: Peyton Creery <44987569+phcreery@users.noreply.github.com>


* bugfix: replace rapidfuzz with thefuzz (#1391)


* gitignore update and update tests for multithread search (#1398)


* misc improvements (#1392)
This reverts commit 5787bea.
Co-authored-by: Silverarmor <23619946+Silverarmor@users.noreply.github.com>


* Multiple Lyrics Providers (#1397)
Co-authored-by: Silverarmor <23619946+Silverarmor@users.noreply.github.com>
Co-authored-by: Jakub Kot <xnetcat.dev@gmail.com>


* misc: fix warnings (#1400)


* revert bea748b: revert to rapidfuzz (#1403)


* ci: cleanup (#1402)


* feat: added path template (#1401)
Co-authored-by: Silverarmor <23619946+Silverarmor@users.noreply.github.com>


Co-authored-by: Jakub Kot <42355410+xnetcat@users.noreply.github.com>
Co-authored-by: Yasser Tahiri <yasserth19@gmail.com>
Co-authored-by: Peyton Creery <44987569+phcreery@users.noreply.github.com>
Co-authored-by: Arbaaz Shafiq <arbaazshafiq@gmail.com>
Co-authored-by: Jakub Kot <xnetcat.dev@gmail.com>
@xnetcat xnetcat deleted the fix-warnings branch October 29, 2021 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Fix PRs that fix bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants