Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert bea748b: revert to rapidfuzz #1403

Merged
merged 1 commit into from Oct 23, 2021
Merged

Conversation

Silverarmor
Copy link
Member

@Silverarmor Silverarmor commented Oct 23, 2021

thefuzz was giving a headache. Revert #1391 back to rapidfuzz.

Title

Description

gone back to using rapidfuzz

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate)

image

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have read the CONTRIBUTING document
  • I have read the CORE VALUES document
  • I have added tests to cover my changes
  • All new and existing tests passed

thefuzz was giving a headache. Revert spotDL#1391 back to rapidfuzz.
@Silverarmor Silverarmor added the Bug Fix PRs that fix bugs label Oct 23, 2021
@xnetcat xnetcat merged commit 20accf7 into spotDL:dev Oct 23, 2021
Silverarmor added a commit that referenced this pull request Oct 24, 2021
* bugfix: don't add cover if spotify does not provide album cover (#1384)


* 🪶: Refactor Code Expression (#1390)
Co-authored-by: Silverarmor <23619946+Silverarmor@users.noreply.github.com>
Co-authored-by: Jakub Kot <42355410+xnetcat@users.noreply.github.com>
Co-authored-by: Peyton Creery <44987569+phcreery@users.noreply.github.com>


* bugfix: replace rapidfuzz with thefuzz (#1391)


* gitignore update and update tests for multithread search (#1398)


* misc improvements (#1392)
This reverts commit 5787bea.
Co-authored-by: Silverarmor <23619946+Silverarmor@users.noreply.github.com>


* Multiple Lyrics Providers (#1397)
Co-authored-by: Silverarmor <23619946+Silverarmor@users.noreply.github.com>
Co-authored-by: Jakub Kot <xnetcat.dev@gmail.com>


* misc: fix warnings (#1400)


* revert bea748b: revert to rapidfuzz (#1403)


* ci: cleanup (#1402)


* feat: added path template (#1401)
Co-authored-by: Silverarmor <23619946+Silverarmor@users.noreply.github.com>


Co-authored-by: Jakub Kot <42355410+xnetcat@users.noreply.github.com>
Co-authored-by: Yasser Tahiri <yasserth19@gmail.com>
Co-authored-by: Peyton Creery <44987569+phcreery@users.noreply.github.com>
Co-authored-by: Arbaaz Shafiq <arbaazshafiq@gmail.com>
Co-authored-by: Jakub Kot <xnetcat.dev@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Fix PRs that fix bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants