Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for hostNetwork and dnsPolicy #212

Merged
merged 1 commit into from
Dec 17, 2019
Merged

Add support for hostNetwork and dnsPolicy #212

merged 1 commit into from
Dec 17, 2019

Conversation

paol
Copy link
Contributor

@paol paol commented Dec 12, 2019

Changes proposed on the PR:

  • Add support for hostNetwork and dnsPolicy in Redis and Sentinel pods

See also issue #109

@paol
Add support for hostNetwork and dnsPolicy
e134ab7 
Adds "hostNetwork" and "dnsPolicy" to types RedisSettings and SentinelSettings. These are just forwarded unchanged to the corresponding PodSpec.
chusAlvarez
chusAlvarez approved these changes Dec 16, 2019
View reviewed changes
Copy link
Contributor

@chusAlvarez chusAlvarez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

¡Thanks a lot! very useful indeed :)

@chusAlvarez chusAlvarez merged commit 3f0086b into spotahome:master Dec 17, 2019
@chusAlvarez chusAlvarez mentioned this pull request Dec 17, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chusAlvarez chusAlvarez chusAlvarez approved these changes

@ese ese Awaiting requested review from ese

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paol @chusAlvarez