Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add REDIS_PASSWORD to server container and use it for readiness probe #235

Merged
merged 1 commit into from
Feb 5, 2020

Conversation

teamon
Copy link
Contributor

@teamon teamon commented Feb 4, 2020

Fixes #218

Changes proposed on the PR:

  • Add REDIS_PASSWORD environment variable (via secret) to redis server container if auth: ... option is used
  • Pass that variable to readiness probe
  • It works both when the variable is set and when it's not

Copy link
Contributor

@chusAlvarez chusAlvarez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

niiiiiice!
Thanks for the fixing :) :) :)

@chusAlvarez chusAlvarez merged commit 11131c8 into spotahome:master Feb 5, 2020
@zedtux
Copy link

zedtux commented Feb 6, 2020

@chusAlvarez If I'm not mistaking, you now have to build a new version of the operator Docker image, right?

Can someone please do it?

@ese
Copy link
Member

ese commented Feb 7, 2020

@zedtux you have it available here docker pull quay.io/spotahome/redis-operator:v1.0.0-rc.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

how redis container readiness scripts coordinate with redis auth
4 participants