Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Installation information in the README #54

Closed
wants to merge 1 commit into from

Conversation

8W9aG
Copy link
Contributor

@8W9aG 8W9aG commented Jan 28, 2016

  • Include static libraries
  • Cocoapods
  • Carthage

* Include static libraries
* Cocoapods
* Carthage
@8W9aG
Copy link
Contributor Author

8W9aG commented Jan 28, 2016

@jgavris
Copy link
Contributor

jgavris commented Jan 28, 2016

Erm it seems coveralls is confused on this one.

@@ -28,6 +28,37 @@ The authentication in this case is abstract, allowing the creator of the SPTData
### Back-off policy :cop:
The data loader service allows rate limiting of URLs to be set explicitly or to be determined by the server using the “Retry-After” semantic. It allows back-off retrying by using a jittered exponential backoff to prevent the thundering hordes creating a request storm after a predictable exponential period has expired.

## Installation
SPTDataLoader can be installed it a variety of ways including traditional static libraries, Cocoapods and Carthage.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace “installed it a” with “installed in a”.

@rastersize
Copy link
Contributor

Very nice! I left a few edit suggestions (from my phone, so my thumbs now hurt 😢)


### CocoaPods
We are indexed on [CocoaPods](http://cocoapods.org) and can be installed with the following commands:
```bash
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the correct one here is shell. However bash maybe also works?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked the rendered output and this is not highlighting it at least. So let's change these to shell instead.

@rastersize
Copy link
Contributor

Closing this in favor of #57.

@rastersize rastersize closed this Jan 29, 2016
rastersize added a commit that referenced this pull request Jan 29, 2016
Add installation information to readme (extends #54)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants