Add tests for Accept-Languages headers for values other than English #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
8W9aG
commented
Jan 29, 2016
8W9aG
commented
- Increase coverage some more
8W9aG
force-pushed
the
add-bundle-test
branch
from
96d818d
to
4545dd1
Compare
|
👍 |
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
| #import <Foundation/Foundation.h> |
|
A small code style comment, as we’ve migrated to Also will we have more swizzeling in tests you think? Should we bring bring over our singleton swizzler? |
|
@rastersize I think this may be a one off (with the NSBundle case). Might make sense to bring in the swizzler once it is open sourced |
|
@8W9aG Alright 👍 |
* Get that coverage up
* Swizzle NSBundle mainBundle and supply our own preferred localizations
8W9aG
force-pushed
the
add-bundle-test
branch
from
8812d71
to
763d0ed
Compare
8W9aG
added a commit
that referenced
this pull request
Jan 30, 2016
Add tests for Accept-Languages headers for values other than English
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.