Add testErrorDelegateCallbackWhenMismatchInChunkSupport #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -71,9 +72,18 @@ - (void)executeDelegateBlock:(dispatch_block_t)block | |||
| { | |||
| SPTDataLoaderRequest *copiedRequest = [request copy]; | |||
| id<SPTDataLoaderDelegate> delegate = self.delegate; | |||
|
|
|||
| // Cancel the request immediately if it requires chunks and the delegate does not support that | |||
| if ([delegate respondsToSelector:@selector(dataLoaderShouldSupportChunks:)] && copiedRequest.chunks) { | |||
There was a problem hiding this comment.
Shouldn't you now also message the delegate in the if-statement to check if it supports chunks?
There was a problem hiding this comment.
Yes you are totally right
|
Could we add a test for the happy case? |
|
@rastersize can do |
8W9aG
force-pushed
the
test-error-chunks
branch
from
0c5fde7
to
69811f9
Compare
|
@rastersize happy case is tested in testRelayReceivedDataChunkToDelegate |
* Test that an error is thrown when the data loader attempts to load a request that requires chunks but the delegate does not support chunks * Removes previous assertion in favor of a less noisy delegate error callback approach
8W9aG
force-pushed
the
test-error-chunks
branch
from
69811f9
to
ca15136
Compare
|
@8W9aG Oh right, nice. 👍 |
8W9aG
added a commit
that referenced
this pull request
Feb 2, 2016
Add testErrorDelegateCallbackWhenMismatchInChunkSupport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
attempts to load a request that requires chunks but
the delegate does not support chunks
noisy delegate error callback approach