Added a flag to disable checking the ssl certificate #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
polac24
reviewed
Jan 16, 2022
| @@ -129,6 +129,8 @@ public struct XCRemoteCacheConfig: Encodable { | |||
| /// `/CoolLibrary/main.swift`will be represented as `$(COOL_LIBRARY)/main.swift`). | |||
| /// Warning: remapping order is not-deterministic so avoid remappings with multiple matchings. | |||
| var outOfBandMappings: [String: String] = [:] | |||
| /// Option to enable/disable TrustManager | |||
| var certificateVerification: Bool = true | |||
There was a problem hiding this comment.
I looked on other tools and found that many of them use a negation of that Bool. Examples:
- Chrome:
--ignore-certificate-errors - git:
GIT_SSL_NO_VERIFY - wget:
--no-check-certificate
Maybe we can have something like:
Suggested change
| var certificateVerification: Bool = true | |
| var disableCertificateVerification: Bool = false |
| @@ -129,6 +129,8 @@ public struct XCRemoteCacheConfig: Encodable { | |||
| /// `/CoolLibrary/main.swift`will be represented as `$(COOL_LIBRARY)/main.swift`). | |||
| /// Warning: remapping order is not-deterministic so avoid remappings with multiple matchings. | |||
| var outOfBandMappings: [String: String] = [:] | |||
| /// Option to enable/disable TrustManager | |||
There was a problem hiding this comment.
TrustManager might be a big obscure for not advanced user. How about:
Suggested change
| /// Option to enable/disable TrustManager | |
| /// If true, SSL certificate validation is disabled |
| @@ -0,0 +1,17 @@ | |||
| // | |||
There was a problem hiding this comment.
Please add a licence comment
|
|
||
| final class IgnoringCertificatesTrustManager: NSObject, URLSessionDelegate { | ||
| func urlSession(_ session: URLSession, didReceive challenge: URLAuthenticationChallenge, completionHandler: @escaping (URLSession.AuthChallengeDisposition, URLCredential?) -> Void) { | ||
| guard let serverTrust = challenge.protectionSpace.serverTrust else { return } |
There was a problem hiding this comment.
We need to call completionHandler anyway in an else
polac24
approved these changes
Jan 16, 2022
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.