-
Notifications
You must be signed in to change notification settings - Fork 209
Conversation
When an ApolloModule installs another ApolloModule, it should start managing lifecycles for all the keys from the installed ApolloModule. Apollo will not manage the installed modules on the service shutdown if we don't do this.
Codecov Report
@@ Coverage Diff @@
## 1.x #357 +/- ##
============================================
+ Coverage 72.04% 72.14% +0.09%
- Complexity 673 676 +3
============================================
Files 137 137
Lines 2862 2868 +6
Branches 167 169 +2
============================================
+ Hits 2062 2069 +7
+ Misses 763 761 -2
- Partials 37 38 +1
Continue to review full report at Codecov.
|
instance.waitForShutdown(); | ||
} | ||
|
||
assertThat(childCreated.get(), is(true)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nitty-pick: What do you think about repeating this at line 462? Something like this could be possible:
try (Service.Instance instance = service.start()) {
assertThat(childCreated.get(), is(true));
assertThat(childClosed.get(), is(false));
instance.getSignaller().signalShutdown();
instance.waitForShutdown();
}
From what I am looking in the code I think it should be fine as they are set in the moment you're creating the instance of the class. What do you think?
Reviewed and approved by weaver squad. |
When an ApolloModule installs another ApolloModule, it should start managing lifecycles for all the keys from the installed ApolloModule.
Apollo will not manage the installed modules on the service shutdown if we don't do this.