Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for bokeh 3.1.0 (>2.0.0) #153

Merged
merged 5 commits into from
Mar 23, 2023

Conversation

vanHekthor
Copy link
Contributor

What this PR does / why we need it:
Makes chartify compatible with bokeh versions >2.0.0 (latest is 3.1.0)
Which issue(s) this PR fixes

fixes #128

Special notes for your reviewer:

Release note:

Support newer bokeh versions (>2.0.0)

@vanHekthor
Copy link
Contributor Author

There is a bug in bokeh (probably version 3 and later) where select(CategoricalColorMapper) returns [] (see here).

This causes some tests to fail.

Thanks to bryevdv I was able to figure out a workaround.

@vanHekthor
Copy link
Contributor Author

@iampelle Maybe support for python <3.8 can be dropped?

Support for Python 3.7 was removed and for 3.10 added.

see https://github.com/bokeh/bokeh/wiki/Migration-Guides#py-300

@iampelle
Copy link
Contributor

iampelle commented Mar 23, 2023

@iampelle Maybe support for python <3.8 can be dropped?

Support for Python 3.7 was removed and for 3.10 added.

see https://github.com/bokeh/bokeh/wiki/Migration-Guides#py-300

Yes, it's about time we drop support for py 3.6 and 3.7! And then we can require bokeh>=3 so that we don't have to check for that, right?

@iampelle iampelle changed the base branch from master to Release-4.0.0 March 23, 2023 10:03
@iampelle iampelle merged commit a7fa5f7 into spotify:Release-4.0.0 Mar 23, 2023
iampelle added a commit that referenced this pull request Mar 23, 2023
* Support for bokeh 3.1.0 (>2.0.0) (#153)

* Fix range args with value None

* Pass range start / end only if not None

* Fix font value for bokeh>=2.3

* Undo pinning bokeh to <2.3.0

* Workaround for select(CategoricalColorMapper) bug
- bug in bokeh>=3.0.0
- bokeh/bokeh#13015

* - Drop python 3.6 and 3.7 from tox testing
- Update version to 4.0.0

* Try to add python 3.11

* Remove 3.11

* Update requirements

* Updated dev requirements

* Reformat and change back flake8 version

* Re-ran example notebook

---------

Co-authored-by: Quoc Duong Bui <35042166+vanHekthor@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When I update bokeh,it take an error
2 participants