Skip to content
This repository has been archived by the owner on Jan 11, 2023. It is now read-only.

crtauth should not raise RuntimeErrors #5

Closed
negz opened this issue Dec 31, 2013 · 0 comments
Closed

crtauth should not raise RuntimeErrors #5

negz opened this issue Dec 31, 2013 · 0 comments

Comments

@negz
Copy link
Contributor

negz commented Dec 31, 2013

https://github.com/spotify/crtauth/search?q=RuntimeError&type=Code
http://docs.python.org/release/2.6.8/library/exceptions.html#exceptions.RuntimeError

crtauth seems to use RuntimeError for a subset of its exceptions. This makes it difficult for consumer code to isolate crtauth exceptions. crtauth should use its own Exception classes.

It also seems like a misleading error to raise - while the documentation doesn't say explicitly I would expect RuntimeErrors to be raised by the Python runtime for things that didn't fall elsewhere.

negz pushed a commit to negz/crtauth that referenced this issue Dec 31, 2013
Change-Id: Iae78d2a126997c0922a4ec133eb107ae44f93e4a
@negz negz closed this as completed Oct 28, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant