You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jan 11, 2023. It is now read-only.
crtauth seems to use RuntimeError for a subset of its exceptions. This makes it difficult for consumer code to isolate crtauth exceptions. crtauth should use its own Exception classes.
It also seems like a misleading error to raise - while the documentation doesn't say explicitly I would expect RuntimeErrors to be raised by the Python runtime for things that didn't fall elsewhere.
The text was updated successfully, but these errors were encountered:
negz
pushed a commit
to negz/crtauth
that referenced
this issue
Dec 31, 2013
https://github.com/spotify/crtauth/search?q=RuntimeError&type=Code
http://docs.python.org/release/2.6.8/library/exceptions.html#exceptions.RuntimeError
crtauth seems to use RuntimeError for a subset of its exceptions. This makes it difficult for consumer code to isolate crtauth exceptions. crtauth should use its own Exception classes.
It also seems like a misleading error to raise - while the documentation doesn't say explicitly I would expect RuntimeErrors to be raised by the Python runtime for things that didn't fall elsewhere.
The text was updated successfully, but these errors were encountered: