This repository has been archived by the owner on Mar 21, 2022. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #154 and #464.
Load and Create
Previously, the various
DockerClient.load(...)
methods all wrapped the/images/create
docker API endpoint, not the/images/load
endpoint as the method name implies. In fact, no methods inDockerClient
wrapped/images/load
.This PR:
DockerClient.load(...)
methods;DockerClient.create(...)
methods, the implementations of which perform the functions thatDefaultDockerClient.load(...)
used to perform;DockerClient.load(ImageStream)
method, the implementation of which calls/images/load
.Save
AuthConfig
when calling/images/{name}/get
. The methodDockerClient.save(String, AuthConfig)
has been deprecated.save
method,DockerClient.save(String)
has been changed toDockerClient.save(String...)
. This is to make use of the two related APIs/images/{name}/get
and/images/get?names=name1&names=name2...
.