Skip to content
This repository has been archived by the owner on Mar 21, 2022. It is now read-only.

Changes to loading and saving #472

Closed
wants to merge 2 commits into from
Closed

Changes to loading and saving #472

wants to merge 2 commits into from

Conversation

johnflavin
Copy link
Contributor

Fix for #154 and #464.

Load and Create

Previously, the various DockerClient.load(...) methods all wrapped the /images/create docker API endpoint, not the /images/load endpoint as the method name implies. In fact, no methods in DockerClient wrapped /images/load.

This PR:

  • Deprecates all existing DockerClient.load(...) methods;
  • Creates two DockerClient.create(...) methods, the implementations of which perform the functions that DefaultDockerClient.load(...) used to perform;
  • Creates a new DockerClient.load(ImageStream) method, the implementation of which calls /images/load.

Save

  • There was no reason to use the AuthConfig when calling /images/{name}/get. The method DockerClient.save(String, AuthConfig) has been deprecated.
  • The other save method, DockerClient.save(String) has been changed to DockerClient.save(String...). This is to make use of the two related APIs /images/{name}/get and /images/get?names=name1&names=name2....

@codecov-io
Copy link

codecov-io commented Jul 8, 2016

Current coverage is 51.58%

Merging #472 into master will increase coverage by 0.15%

@@             master       #472   diff @@
==========================================
  Files            80         80          
  Lines          2973       2989    +16   
  Methods           0          0          
  Messages          0          0          
  Branches        417        421     +4   
==========================================
+ Hits           1529       1542    +13   
- Misses         1308       1310     +2   
- Partials        136        137     +1   

Powered by Codecov. Last updated by cfeff16...940626a

@davidxia
Copy link
Contributor

Rebased here #494

@davidxia davidxia closed this Sep 21, 2016
@johnflavin johnflavin deleted the load branch September 23, 2016 18:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants