This repository has been archived by the owner on Feb 2, 2021. It is now read-only.
Add workaround for Python 2.6. #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -53,7 +53,9 @@ function ElapsedTime() { | |||
| from datetime import datetime,timedelta | |||
| now = datetime.utcnow() | |||
| exited = datetime.strptime("${1}".replace("Z","").split('.')[0], "%Y-%m-%dT%H:%M:%S") | |||
| print int((now - exited).total_seconds()) | |||
| difference = now - exited | |||
| differenceTotalSeconds = (difference.microseconds + (difference.seconds + difference.days*24*3600) * 1e6) / 1e6 | |||
There was a problem hiding this comment.
I think we can disregard microseconds accuracy and just make this
differenceTotalSeconds = difference.seconds + difference.days*24*3600
|
Minor comment only, otherwise 👍 Thanks! |
|
Thanks for the feedback, PR updated. |
mbruggmann
added a commit
that referenced
this pull request
Dec 12, 2014
Add workaround for Python 2.6.
davidxia
pushed a commit
that referenced
this pull request
May 23, 2018
* bump docker version and fix binary mv * add volume cleanup * mention volumes in readme * keep docker-gc backward-compatibility * improve remove volumes logic * this would probably be a feature * change back to original docker version * exclude volumes removal * add VOLUME_DELETE_ONLY_DRIVER * fix typos (#6) * exclude volumes file defaults to null (#7) * it should be local, not locale (#8) * Add dangling images to list of all images. (#9)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python 2.6 does not include the
total_secondsmethod fordatetime.timedeltahttps://docs.python.org/2/library/datetime.html#datetime.timedelta.total_seconds