Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump google format & other dependencies #188

Merged
merged 2 commits into from
Mar 7, 2024
Merged

Conversation

caesar-ralf
Copy link
Contributor

Do some cleanup and bump google format to https://github.com/google/google-java-format/releases/tag/v1.21.0

Copy link
Contributor

@andreasfolkesson andreasfolkesson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The build is failing with a formatting problem.

@caesar-ralf
Copy link
Contributor Author

The build is failing with a formatting problem.

fixed. It was not really a format, but because changing the scope of one dependency ended up causing the tests to fail

Copy link
Contributor

@andreasfolkesson andreasfolkesson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@caesar-ralf caesar-ralf merged commit 645ace3 into main Mar 7, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants