Skip to content
This repository has been archived by the owner on Mar 27, 2021. It is now read-only.

[statistics] use SlidingTimeWindowArrayReservoir for histograms #649

Merged
merged 2 commits into from
Apr 27, 2020

Conversation

dmichel1
Copy link
Contributor

Rather than using a custom reservoir in a few places use the new SlidingTimeWindowArrayReservoir everywhere.

This will ensure all histograms values decay in a timely fashion with low traffic and also accurately capture min and max values.

https://medium.com/expedia-group-tech/your-latency-metrics-could-be-misleading-you-how-hdrhistogram-can-help-9d545b598374 goes more into the details about what is wrong with the current histogram implantation.

dropwizard/metrics#1139 and https://metrics.dropwizard.io/4.0.0/manual/core.html#sliding-time-window-reservoirs

Rather than using a custom reservoir in a few places use the new SlidingTimeWindowArrayReservoir everywhere.

This will ensure all histograms values decay in a timely fashion with low traffic and also accurately capture min and max values.

https://medium.com/expedia-group-tech/your-latency-metrics-could-be-misleading-you-how-hdrhistogram-can-help-9d545b598374 goes more into the details about what is wrong with the current histogram implantation.

dropwizard/metrics#1139 and https://metrics.dropwizard.io/4.0.0/manual/core.html#sliding-time-window-reservoirs
@codecov
Copy link

codecov bot commented Apr 27, 2020

Codecov Report

Merging #649 into master will decrease coverage by 0.08%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #649      +/-   ##
============================================
- Coverage     53.12%   53.04%   -0.09%     
+ Complexity     2951     2938      -13     
============================================
  Files           728      726       -2     
  Lines         19581    19526      -55     
  Branches       1294     1289       -5     
============================================
- Hits          10402    10357      -45     
+ Misses         8736     8728       -8     
+ Partials        443      441       -2     
Impacted Files Coverage Δ Complexity Δ
.../statistics/semantic/SemanticConsumerReporter.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...istics/semantic/SemanticMetricBackendReporter.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
.../statistics/semantic/SemanticStatisticsModule.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15967c7...30d1770. Read the comment docs.

@dmichel1 dmichel1 merged commit 9c2d81b into master Apr 27, 2020
@delete-merged-branch delete-merged-branch bot deleted the dmichel/metrics branch April 27, 2020 19:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants