This repository has been archived by the owner on Mar 27, 2021. It is now read-only.
[statistics] use SlidingTimeWindowArrayReservoir for histograms #649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than using a custom reservoir in a few places use the new SlidingTimeWindowArrayReservoir everywhere. This will ensure all histograms values decay in a timely fashion with low traffic and also accurately capture min and max values. https://medium.com/expedia-group-tech/your-latency-metrics-could-be-misleading-you-how-hdrhistogram-can-help-9d545b598374 goes more into the details about what is wrong with the current histogram implantation. dropwizard/metrics#1139 and https://metrics.dropwizard.io/4.0.0/manual/core.html#sliding-time-window-reservoirs
sjoeboo
approved these changes
Apr 27, 2020
dmichel1
force-pushed
the
dmichel/metrics
branch
from
0b0d900
to
30d1770
Compare
Codecov Report
@@ Coverage Diff @@
## master #649 +/- ##
============================================
- Coverage 53.12% 53.04% -0.09%
+ Complexity 2951 2938 -13
============================================
Files 728 726 -2
Lines 19581 19526 -55
Branches 1294 1289 -5
============================================
- Hits 10402 10357 -45
+ Misses 8736 8728 -8
+ Partials 443 441 -2
Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than using a custom reservoir in a few places use the new SlidingTimeWindowArrayReservoir everywhere.
This will ensure all histograms values decay in a timely fashion with low traffic and also accurately capture min and max values.
https://medium.com/expedia-group-tech/your-latency-metrics-could-be-misleading-you-how-hdrhistogram-can-help-9d545b598374 goes more into the details about what is wrong with the current histogram implantation.
dropwizard/metrics#1139 and https://metrics.dropwizard.io/4.0.0/manual/core.html#sliding-time-window-reservoirs