Make logging of RPC retries configurable #2486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This simplifies away unnecessary propagation, cleans up argument lists. As far as I can tell, log_exceptions is True in all execution paths. It seems that 6dfe9af removed the last occasion of it being (spuriously) set to False.
ulzha
force-pushed
the
ulzha/rpc-log-retries
branch
from
0978652
to
d2d3944
Compare
Tarrasch
approved these changes
Aug 11, 2018
| @@ -116,31 +116,34 @@ def __init__(self, url='http://localhost:8082/', connect_timeout=None): | |||
|
|
|||
| self._rpc_retry_attempts = config.getint('core', 'rpc-retry-attempts', 3) | |||
| self._rpc_retry_wait = config.getint('core', 'rpc-retry-wait', 30) | |||
| self._rpc_log_retries = config.getboolean('core', 'rpc-log-retries', True) | |||
There was a problem hiding this comment.
Oh, this part of the code still doesn't use the config class syntax? Oh well maybe better done in a separate PR.
| try: | ||
| self.get_work(fetch_results) | ||
| self.fail("get_work should have thrown RPCError") | ||
| except luigi.rpc.RPCError as e: |
There was a problem hiding this comment.
Can't you use self.assertRaises?
There was a problem hiding this comment.
This was done to assert about e.sub_exception.
dlstadther
approved these changes
Aug 12, 2018
ulzha
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Logging of intermittent RPC exceptions and retries as they happen makes logs spammy and obscures other errors, so we want a way to disable it. If the exceptions persist, the final RPCError does log the last exception anyway.
Especially when long running (hanging, even) tasks are considered, with periods of silence in the logs, any intermittent "Failed connecting to remote scheduler" logging from KeepAliveThread looks very flashy and misleads troubleshooting often, in our experience.
The health of communication channels (presence of intermittent failures) probably should be easy to monitor through dedicated tooling, as opposed to logging it interspersed with task logs.
Have you tested this? If so, how?
Ought to be covered with unit tests.