Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error message #611

Merged
merged 1 commit into from
Oct 5, 2022
Merged

Improve error message #611

merged 1 commit into from
Oct 5, 2022

Conversation

RustedBones
Copy link
Contributor

Error message is using toString of complex TypeName

@codecov
Copy link

codecov bot commented Oct 5, 2022

Codecov Report

Merging #611 (d3a154c) into main (353025d) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #611   +/-   ##
=======================================
  Coverage   96.11%   96.11%           
=======================================
  Files          48       48           
  Lines        1648     1649    +1     
  Branches      152      152           
=======================================
+ Hits         1584     1585    +1     
  Misses         64       64           
Impacted Files Coverage Δ
...red/src/main/scala/magnolify/shared/EnumType.scala 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@RustedBones RustedBones merged commit 790ff86 into main Oct 5, 2022
@RustedBones RustedBones deleted the improve-error branch October 5, 2022 10:17
shnapz added a commit that referenced this pull request Oct 13, 2022
Implemented SchemaUtil deepCopy with parquet annotations enrichment

Fix errors

Added more tests

Improve error message (#611)

Make implicit field from EnumType low priority (#613)

Fix build
shnapz added a commit that referenced this pull request Oct 13, 2022
Implemented SchemaUtil deepCopy with parquet annotations enrichment

Fix errors

Added more tests

Improve error message (#611)

Make implicit field from EnumType low priority (#613)

Fix build
shnapz added a commit that referenced this pull request Oct 13, 2022
Implemented SchemaUtil deepCopy with parquet annotations enrichment

Fix errors

Added more tests

Improve error message (#611)

Make implicit field from EnumType low priority (#613)

Fix build
shnapz added a commit that referenced this pull request Oct 14, 2022
Implemented SchemaUtil deepCopy with parquet annotations enrichment

Fix errors

Added more tests

Improve error message (#611)

Make implicit field from EnumType low priority (#613)

Fix build
shnapz added a commit that referenced this pull request Oct 14, 2022
* Collecting parquet annotations and storing them in the map

Implemented SchemaUtil deepCopy with parquet annotations enrichment

Fix errors

Added more tests

Improve error message (#611)

Make implicit field from EnumType low priority (#613)

Fix build

* Improve parquet annotation support

* dded more checks into AvroSchemaComparer

* address review comments

* address review comments 2

* Addressed PR comments

Co-authored-by: Michel Davit <micheld@spotify.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant