-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup tests #616
Cleanup tests #616
Conversation
373442e
to
f42aea5
Compare
Codecov Report
@@ Coverage Diff @@
## main #616 +/- ##
=======================================
Coverage 94.97% 94.97%
=======================================
Files 51 51
Lines 1770 1771 +1
Branches 185 185
=======================================
+ Hits 1681 1682 +1
Misses 89 89
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great! i have only a minor nitpick 🎨
@@ -352,8 +321,8 @@ case class MapPrimitive(m: Map[String, Int]) | |||
case class MapNested(m: Map[String, Nested]) | |||
|
|||
case class Logical(u: UUID, d: LocalDate) | |||
case class LogicalMicros(bd: BigDecimal, i: Instant, t: LocalTime, dt: LocalDateTime) | |||
case class LogicalMillis(bd: BigDecimal, i: Instant, t: LocalTime, dt: LocalDateTime) | |||
case class LogicalMicros(i: Instant, t: LocalTime, dt: LocalDateTime) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 good catch
scalacheck/src/test/scala/magnolify/scalacheck/test/TestArbitrary.scala
Outdated
Show resolved
Hide resolved
9e20f33
to
3c86a43
Compare
scalacheck/src/test/scala/magnolify/scalacheck/CogenDerivationSuite.scala
Show resolved
Hide resolved
c4534ce
to
3cbb33e
Compare
Cache the type-class test instances for
Arbitrary
,Eq
andEnumType
to avoid macro generation in every test suite.Flatten test structure