Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup tests #616

Merged
merged 9 commits into from
Oct 17, 2022
Merged

Cleanup tests #616

merged 9 commits into from
Oct 17, 2022

Conversation

RustedBones
Copy link
Contributor

Cache the type-class test instances for Arbitrary, Eq and EnumType to avoid macro generation in every test suite.
Flatten test structure

@codecov
Copy link

codecov bot commented Oct 12, 2022

Codecov Report

Merging #616 (3cbb33e) into main (da3d3a1) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #616   +/-   ##
=======================================
  Coverage   94.97%   94.97%           
=======================================
  Files          51       51           
  Lines        1770     1771    +1     
  Branches      185      185           
=======================================
+ Hits         1681     1682    +1     
  Misses         89       89           
Impacted Files Coverage Δ
avro/src/main/scala/magnolify/avro/AvroType.scala 96.39% <ø> (ø)
...red/src/main/scala/magnolify/shared/EnumType.scala 100.00% <ø> (ø)
...rc/main/scala/magnolify/parquet/ParquetField.scala 95.74% <100.00%> (+0.02%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@clairemcginty clairemcginty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! i have only a minor nitpick 🎨

@@ -352,8 +321,8 @@ case class MapPrimitive(m: Map[String, Int])
case class MapNested(m: Map[String, Nested])

case class Logical(u: UUID, d: LocalDate)
case class LogicalMicros(bd: BigDecimal, i: Instant, t: LocalTime, dt: LocalDateTime)
case class LogicalMillis(bd: BigDecimal, i: Instant, t: LocalTime, dt: LocalDateTime)
case class LogicalMicros(i: Instant, t: LocalTime, dt: LocalDateTime)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 good catch

cats/src/test/scala/magnolify/cats/test/TestEq.scala Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants