Parquet map logical type #876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #876 +/- ##
==========================================
- Coverage 95.21% 95.17% -0.04%
==========================================
Files 51 51
Lines 1777 1825 +48
Branches 175 157 -18
==========================================
+ Hits 1692 1737 +45
- Misses 85 88 +3 ☔ View full report in Codecov by Sentry. |
clairemcginty
approved these changes
Dec 18, 2023
parquet/src/test/scala/magnolify/parquet/ParquetTypeSuite.scala
Outdated
Show resolved
Hide resolved
RustedBones
force-pushed
the
parquet-map
branch
from
06f6313
to
17ab320
Compare
clairemcginty
approved these changes
Jan 5, 2024
| .named("map") | ||
| } | ||
|
|
||
| override val hasAvroArray: Boolean = pfKey.hasAvroArray || pfValue.hasAvroArray |
There was a problem hiding this comment.
I almost think we should throw an error if there's an hasAvroArray mismatch between key and value (and they both contain repeated types), since that probably points to a user error... that said, an iterable key is enough of an edge case it might not be worth implementing 😅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementing
Map[K, V]as described by parquet MAP logical type documentation