Skip to content
This repository has been archived by the owner on Jul 12, 2023. It is now read-only.

Handle error state #1059

Merged
merged 6 commits into from
Jul 5, 2023
Merged

Handle error state #1059

merged 6 commits into from
Jul 5, 2023

Conversation

honnix
Copy link
Member

@honnix honnix commented Mar 16, 2023

Hey, I just made a Pull Request!

Description

Handle ERROR state in FlyteRunnerHandler.

Motivation and Context

ERROR state is driven by halt event, and when that happens, we should terminate the execution in Flyte.

We are not doing the same treatment to DockerRunnerHandler because halting we have a dedicated thread reaping pods, see

scheduleWithJitter(this::cleanupPods, scheduledExecutor, cleanupPodsInterval);
and

Have you tested this? If so, how?

Checklist for PR author(s)

  • Changes are covered by unit test
  • All tests pass
  • Code coverage check passes
  • Error handling is tested
  • Errors are handled at the appropriate layer
  • Errors that cannot be handled where they occur are propagated
  • (optional) Changes are covered by system test
  • Relevant documentation updated
  • This PR has NO breaking change to public API
  • This PR has breaking change to public API and it is documented

Checklist for PR reviewer(s)

  • This PR has been incorporated in release note for the coming version
  • Risky changes introduced by this PR have been all considered

@@ -70,7 +70,7 @@ public final void transitionInto(RunState state, EventRouter eventRouter) {
}
safeTransitionInto(state, eventRouter);
break;

case ERROR:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ERROR state is driven by halt event.

@codecov
Copy link

codecov bot commented Jul 5, 2023

Codecov Report

Merging #1059 (b49bbc7) into master (0b30611) will increase coverage by 0.07%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master    #1059      +/-   ##
============================================
+ Coverage     92.28%   92.36%   +0.07%     
- Complexity     2149     2151       +2     
============================================
  Files           200      200              
  Lines          8325     8326       +1     
  Branches        503      504       +1     
============================================
+ Hits           7683     7690       +7     
+ Misses          526      521       -5     
+ Partials        116      115       -1     

@andresgomezfrr andresgomezfrr marked this pull request as ready for review July 5, 2023 11:01
@pablocasares pablocasares merged commit f4d6e3f into master Jul 5, 2023
@pablocasares pablocasares deleted the halt branch July 5, 2023 11:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants