This repository has been archived by the owner on Jul 12, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, I just made a Pull Request!
Description
Handle
ERROR
state inFlyteRunnerHandler
.Motivation and Context
ERROR
state is driven byhalt
event, and when that happens, we should terminate the execution in Flyte.We are not doing the same treatment to
DockerRunnerHandler
because halting we have a dedicated thread reaping pods, seestyx/styx-scheduler-service/src/main/java/com/spotify/styx/docker/KubernetesDockerRunner.java
Line 537 in efaf212
styx/styx-scheduler-service/src/main/java/com/spotify/styx/docker/KubernetesDockerRunner.java
Line 449 in efaf212
Have you tested this? If so, how?
Checklist for PR author(s)
Checklist for PR reviewer(s)