Skip to content
This repository has been archived by the owner on Jul 12, 2023. It is now read-only.

Hide sensitive headers properly #1090

Merged
merged 2 commits into from
Jun 28, 2023
Merged

Hide sensitive headers properly #1090

merged 2 commits into from
Jun 28, 2023

Conversation

honnix
Copy link
Member

@honnix honnix commented Jun 28, 2023

Hey, I just made a Pull Request!

Description

Hide sensitive headers properly by ignoring case.

Motivation and Context

HTTP header is case in sensitive, so we cannot assume any case.

Have you tested this? If so, how?

This is covered by unit test.

Checklist for PR author(s)

  • Changes are covered by unit test
  • All tests pass
  • Code coverage check passes
  • Error handling is tested
  • Errors are handled at the appropriate layer
  • Errors that cannot be handled where they occur are propagated
  • (optional) Changes are covered by system test
  • Relevant documentation updated
  • This PR has NO breaking change to public API
  • This PR has breaking change to public API and it is documented

Checklist for PR reviewer(s)

  • This PR has been incorporated in release note for the coming version
  • Risky changes introduced by this PR have been all considered

@codecov
Copy link

codecov bot commented Jun 28, 2023

Codecov Report

Merging #1090 (646b186) into master (00a37c4) will decrease coverage by 0.12%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master    #1090      +/-   ##
============================================
- Coverage     92.35%   92.23%   -0.12%     
  Complexity     2148     2148              
============================================
  Files           200      200              
  Lines          8321     8323       +2     
  Branches        503      503              
============================================
- Hits           7685     7677       -8     
- Misses          520      531      +11     
+ Partials        116      115       -1     

@honnix
Copy link
Member Author

honnix commented Jun 28, 2023

I'm positive this is covered by unit test, not sure why codecov is sad.

@honnix honnix merged commit 0575e5b into master Jun 28, 2023
@honnix honnix deleted the hide-sensitive-header branch June 28, 2023 15:37
@honnix honnix mentioned this pull request Jun 28, 2023
12 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants