Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(web-scripts): use commander 5 #314

Merged
merged 1 commit into from
Apr 28, 2020
Merged

build(web-scripts): use commander 5 #314

merged 1 commit into from
Apr 28, 2020

Conversation

fastfrwrd
Copy link

BREAKING CHANGE: running web-scripts without arguments exits code 1 now instead of exiting 0

BREAKING CHANGE: running web-scripts without arguments exits code 1 now instead of exiting 0
@fastfrwrd fastfrwrd changed the base branch from master to 7.0-release April 27, 2020 20:39
@fastfrwrd fastfrwrd merged commit 27a6be3 into 7.0-release Apr 28, 2020
@fastfrwrd fastfrwrd deleted the commander-5 branch April 28, 2020 13:09
fastfrwrd pushed a commit that referenced this pull request Apr 28, 2020
BREAKING CHANGE: running web-scripts without arguments exits code 1 now instead of exiting 0
fastfrwrd pushed a commit that referenced this pull request Apr 28, 2020
BREAKING CHANGE: running web-scripts without arguments exits code 1 now instead of exiting 0
fastfrwrd pushed a commit that referenced this pull request Apr 28, 2020
* build(web-scripts): use commander 5 (#314)

BREAKING CHANGE: running web-scripts without arguments exits code 1 now instead of exiting 0

* feat: prettier 2.0; update project to use top-level lint and format (#312)

- updating the project to use prettier 2.0

BREAKING CHANGE: prettier 2.0 may introduce breaking changes

* improvement(web-scripts): make stylecheck and typecheck default for lint (#310)

* feat: prettier 2.0; update project to use top-level lint and format

- updating the project to use prettier 2.0

BREAKING CHANGE: prettier 2.0 may introduce breaking changes

* improvement(web-scripts): make stylecheck and typecheck default for lint

the lint script will now default typechecking and stylechecking to true by default. You may shut
these off with `--no-typecheck` and `--no-stylecheck`.

BREAKING CHANGE: Users who have projects incompatible with TypeScript checks or with projects that
do not user prettier will now fail yarn lint.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant