Move implicits to correct companion object #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
jrudolph
force-pushed
the
jr/move-implicits-to-correct-companion-object
branch
from
4ea80a8
to
faae565
Compare
jrudolph
force-pushed
the
jr/move-implicits-to-correct-companion-object
branch
2 times, most recently
from
31fd8d6
to
9ff2746
Compare
…import necessary any more)
jrudolph
force-pushed
the
jr/move-implicits-to-correct-companion-object
branch
from
9ff2746
to
b8004c4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To keep it compatible we just remove the
implicitmarker for now and provide implicit forwarders in traits that are mixed intoJsonFormat.Later we should deprecate usage (and especially inheritance) of
BasicFormatsetc. and recommend to use the methods in JsonFormat directly.Refs #308.