Skip to content
This repository has been archived by the owner on Apr 5, 2022. It is now read-only.

AbstractSitePathUrlFactory doesn't handle empty paths correctly #22

Closed
evpaassen opened this issue Oct 1, 2014 · 1 comment
Closed

AbstractSitePathUrlFactory doesn't handle empty paths correctly #22

evpaassen opened this issue Oct 1, 2014 · 1 comment

Comments

@evpaassen
Copy link
Contributor

The formatPath(String path) AbstractSitePathUrlFactory class doesn't handle an empty path (empty String) correctly. It will return // (two slashes), instead of just one.

The error seems to be on line 197, where it should check if formattedPath ends with a slash, instead of path. I will create a PR with an accompanying test.
evpaassen added a commit to evpaassen/spring-mobile that referenced this issue Oct 1, 2014
@evpaassen
Fix handling of empty paths in AbstractSitePathUrlFactory.
24a393c 
The formatPath(String path) AbstractSitePathUrlFactory class didn't
handle an empty path (empty String) correctly. It would return //
(two slashes), instead of just one.

Fixes spring-attic#22.
@evpaassen
Copy link
Contributor Author

I created a issue in JIRA, so this one can be closed.
https://jira.spring.io/browse/MOBILE-113

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@evpaassen