Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider reinstating tags-as-metadata option #699

Open
spencergibb opened this issue Jan 15, 2021 · 5 comments
Open

Consider reinstating tags-as-metadata option #699

spencergibb opened this issue Jan 15, 2021 · 5 comments
Labels
enhancement

Comments

@spencergibb
Copy link
Member

spencergibb commented Jan 15, 2021 •
edited
Loading

See #696 and #698. Please vote using the reaction feature of THIS comment.

image
This was referenced Jan 15, 2021
Closed
Closed
lucasoares added a commit to lucasoares/spring-cloud-consul that referenced this issue Jan 15, 2021
@lucasoares
Adds metadata and tags merging to rollback breaking change. See sprin…
8381af2 
…g-cloud#699 original repository issue
lucasoares added a commit to lucasoares/spring-cloud-consul that referenced this issue Jan 15, 2021
@lucasoares
Adds metadata and tags merging to rollback breaking change. See sprin…
e209a6f 
…g-cloud#699 original repository issue
@spencergibb
Copy link
Member Author

@lucasoares PR?

@lucasoares
Copy link

lucasoares commented Jan 20, 2021 •
edited
Loading

@spencergibb I can make it.. I just forked to be able to fix my problem as fast as possible and after that I had no time to do it.

I will have to change the default value to false right?

@spencergibb
Copy link
Member Author

@lucasoares yes, default to false.

lucasoares added a commit to lucasoares/spring-cloud-consul that referenced this issue Jan 20, 2021
@lucasoares
Reinstate tags-as-metadata by adding option to merge tags with metada…
ff5368a 
…ta. Fixes spring-cloud#699
@lucasoares lucasoares mentioned this issue Jan 20, 2021
Closed
@lucasoares
Copy link

lucasoares commented Jan 20, 2021 •
edited
Loading

Please validate my solution and inform me any remaining changes I need to do: #700

Thanks.

@HaojunRen
Copy link

That means spring.cloud.consul.discovery.metadata.version=1.0 and spring.cloud.consul.discovery.tags=version=1.0 are all supported?

@spencergibb spencergibb linked a pull request Mar 12, 2021 that will close this issue
Reinstate tags-as-metadata adding option to merge tags. Fixes #699 #700
Closed
hamigam pushed a commit to hamigam/spring-cloud-consul that referenced this issue Apr 6, 2022
@lucasoares
Reinstate tags-as-metadata by adding option to merge tags with metada…
6a2a550 
…ta. Fixes spring-cloud#699
hamigam added a commit to hamigam/spring-cloud-consul that referenced this issue Apr 6, 2022
@hamigam
Read isSecure also from tags when tag merging into meta is enabled. A…
baa22a6 
…dd test. Fixes spring-cloud#699
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Reinstate tags-as-metadata adding option to merge tags. Fixes #699 lucasoares/spring-cloud-consul
3 participants
@spencergibb @lucasoares @HaojunRen