-
Notifications
You must be signed in to change notification settings - Fork 580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: enable ctr for prometheus reporting #5362
Conversation
@cppwfs - I think there are still references of the build which points to the spring repository instead of central. |
No this issue is not the same. This PR solves the issue that the CTR sends the metrics to the Prometheus Proxy as the dependencies were only scope test which was wrong. The issue linked by you occurs if you scale up the replicas of SCDF to 2 or higher. When you do so there are two instances of the SCDF server reporting the values to prometheus with the same application. So one overrides the values of the other. In this case the dashboard needs to be adjusted. In the issue itself I mentioned how to fix this. |
Whoops! You are correct. I'll remove my comment from before to remove confusion. |
The docresources is still and issue. I thought the changes was in. |
Probably need to add an application.properties where Prometheus is disabled by default. i.e. |
As far as I know those properties are disabled by default, but given when ever Prometheus RSocket Proxy is enabled in the SCDF. I think separate properties are not needed. |
Thanks @cppwfs and @klopfdreh. They are indeed disabled by default here. I have not caught up on this thread but will digest shortly to see if I have anything to add. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM @klopfdreh - thanks for another excellent contribution!
Closed via 5df193a |
Currently the CTR does not report to prometheus-rsocket-proxy - even if the environment variables are given from the SCDF server. With this fix the CTR is reporting to the prometheus-rsocket-proxy like all other task applications