Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sleuth integration #20

Closed
spencergibb opened this issue Feb 9, 2017 · 6 comments
Closed

Sleuth integration #20

spencergibb opened this issue Feb 9, 2017 · 6 comments

Comments

@spencergibb
Copy link
Member

No description provided.

@cforce
Copy link

cforce commented Apr 12, 2017

Interesting feature would be to extend zipking view with data from client/user that is part of the auth token - of course this data security critical- but very can be helpful for filtering for monitoring on e.g. early birding requests for special clients/user

@evenh
Copy link

evenh commented Feb 21, 2018

Wouldn't the TraceWebFilter do the trick?

@spencergibb
Copy link
Member Author

It's part of the answer. The Netty http client needs to be instrumented as well to pass tracing downstream

@cer
Copy link

cer commented Mar 4, 2018

What's the status of this issue? Any ETA?

I am using spring-cloud-gateway:2.0.0.M8 and spring-cloud-sleuth:2.0.0.M8
Zipkin shows inbound HTTP request to the API Gateway but does not show the outbound requests made either via API Gateway routing or explicit WebClient calls.

@spencergibb
Copy link
Member Author

There's an issue in sleuth for this as well that has been closed, but wasn't release last week. We need to verify that it's all working in snapshots.

@evenh
Copy link

evenh commented Mar 14, 2018

This commit landed in 2.0.0.M8

spencergibb added a commit that referenced this issue Feb 22, 2019
Also tests Metadata.matches()

See gh-20
jhonyelink added a commit to jhonyelink/spring-cloud-gateway that referenced this issue Aug 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants