-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade azure-spring-apps-maven-plugin to 1.16.0 #17
base: main
Are you sure you want to change the base?
Upgrade azure-spring-apps-maven-plugin to 1.16.0 #17
Conversation
chenrujun
commented
Apr 7, 2023
- Upgrade azure-spring-apps-maven-plugin to 1.16.0.
- Add some information about known issues about azure-spring-apps-maven-plugin:1.16.0
Hi, @Buzzardo. Could you please help to review this PR? |
Hi, @stliu, @dingmeng-xue, @wangmingliang-ms. |
* Expose public access for this app boot-for-azure? (y/N): y | ||
* For other options, just select the default value. | ||
- Here is a sample terminal output: | ||
- This maven goal will first authenticate with Azure, if you have logged in with https://docs.microsoft.com/en-us/cli/azure/[Azure CLI], it will consume its existing authentication token. Otherwise, it will get you logged in with https://github.com/microsoft/azure-maven-plugins/wiki/Azure-Maven-Plugin/[azure-maven-plugin] automatically. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change to:
This maven goal first authenticates with Azure. if you have logged in with https://docs.microsoft.com/en-us/cli/azure/[Azure CLI], it consumes its existing authentication token. Otherwise, it automatically logs you in with https://github.com/microsoft/azure-maven-plugins/wiki/Azure-Maven-Plugin/[azure-maven-plugin].
- Here is a sample terminal output: | ||
- This maven goal will first authenticate with Azure, if you have logged in with https://docs.microsoft.com/en-us/cli/azure/[Azure CLI], it will consume its existing authentication token. Otherwise, it will get you logged in with https://github.com/microsoft/azure-maven-plugins/wiki/Azure-Maven-Plugin/[azure-maven-plugin] automatically. | ||
|
||
- After login successfully, you will get the subscription list like this: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change to:
After successfully logging in, you see the subscription list:
Select subscription [1-xx] (1): | ||
---- | ||
+ | ||
IMPORTANT: If there is error like `Execution of class com.microsoft.aad.msal4j.AcquireTokenSilentSupplier failed.` and get the subscription list successfully. You can just ignore the error and continue the following steps. Here is more information about this error: https://github.com/microsoft/azure-maven-plugins/issues/2270[azure-maven-plugins#2270]. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change to:
IMPORTANT: If you see an error similar to Execution of class com.microsoft.aad.msal4j.AcquireTokenSilentSupplier failed.
and get the subscription list, you can ignore the error and continue. For more information about the error, see https://github.com/microsoft/azure-maven-plugins/issues/2270[azure-maven-plugins#2270].
+ | ||
IMPORTANT: If there is error like `Execution of class com.microsoft.aad.msal4j.AcquireTokenSilentSupplier failed.` and get the subscription list successfully. You can just ignore the error and continue the following steps. Here is more information about this error: https://github.com/microsoft/azure-maven-plugins/issues/2270[azure-maven-plugins#2270]. | ||
|
||
- Select the subscription which host the Azure Spring Apps you just created. Then you will get the Azure Spring Apps list: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change to:
Select the subscription that hosts the Azure Spring Apps you created. Then you see the Azure Spring Apps list:
Select Azure Spring Apps for deployment: [1-xx] (1): | ||
---- | ||
+ | ||
IMPORTANT: If there is error like `does not support the API version '2022-09-01-preview'` and get the Azure Spring Apps instance list successfully. You can just ignore the error and continue the following steps. Here is more information about this error: https://github.com/microsoft/azure-maven-plugins/issues/2268[azure-maven-plugins#2268]. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change to:
IMPORTANT: If you see an error similar to does not support the API version '2022-09-01-preview'
and get the Azure Spring Apps instance list, you can ignore the error and continue. For more information about the error, see https://github.com/microsoft/azure-maven-plugins/issues/2268[azure-maven-plugins#2268].
[INFO] Using Azure Spring Apps: xxx | ||
Input the app name (demo): | ||
Expose public access for this app boot-for-azure? (y/N):y | ||
[INFO] There is only one valid runtime (Java 17) for your project, will use it automatically. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change to:
[INFO] There is only one valid runtime (Java 17) for your project, which automatically uses it.