Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorporate /storage into tutorial #33

Closed
ptMcGit opened this issue Dec 8, 2016 · 4 comments
Closed

Incorporate /storage into tutorial #33

ptMcGit opened this issue Dec 8, 2016 · 4 comments
Labels
bug

Comments

@ptMcGit
Copy link

ptMcGit commented Dec 8, 2016 •
edited
Loading

In README.adoc the section "Make the application executable" can't be completed without /storage in place i.e. there needs to be a section for adding the files in src/main/java/hello/storage.

Sorry about the confusion.
@dsyer
Copy link
Contributor

dsyer commented Dec 8, 2016

What is "/storage"? What do you have to do to put it "in place"? (I don't have to do anything special. Just run the app from the command line.)

@Avec112
Copy link

Avec112 commented Dec 10, 2016

I think ptMcGit maybe is refering to the documentation https://spring.io/guides/gs/uploading-files/ and the fact that you have to get the storage files from repo while the controller for instance is available from the article.

@dsyer
Copy link
Contributor

dsyer commented Dec 10, 2016

I see. There is a StorageService in the sample app that isn't mentioned anywhere in the text.

@dsyer dsyer added the bug label Dec 10, 2016
@AndreiD
Copy link

AndreiD commented Jul 27, 2017

up this issue. C'mon man!!!

@dsyer dsyer closed this as completed in 6da1d88 Jul 28, 2017
newlight77 pushed a commit to newlight77/kata-uploading-files that referenced this issue Mar 24, 2018
@dsyer
Add StorageService interface snippet and a note about it
dd3dbc6 
We don't want to get into a blow-by-blow account of the implementation
so I think it's best to just show the interface and explain that
an implementation is available.

Fixes spring-guidesgh-33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@dsyer @AndreiD @Avec112 @ptMcGit