Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update sidebar #251

Merged
merged 3 commits into from
Jun 14, 2024
Merged

feat: Update sidebar #251

merged 3 commits into from
Jun 14, 2024

Conversation

oodamien
Copy link
Collaborator

@philwebb
Copy link
Contributor

I don't see a difference for the page/not page items in the tree. Here's a commit that updates the preview philwebb@2b1ff69

@philwebb
Copy link
Contributor

I wonder if we should also keep the chevron color the same as the text. It's the same when no selected, but when selected the text and chevron are different colors.

Screenshot 2024-05-28 at 11 38 55 AM

Screenshot 2024-05-28 at 11 39 01 AM

@philwebb
Copy link
Contributor

When comparing to the stock Antora UI I think there are a couple of tweaks we should consider:

Screenshot 2024-06-13 at 5 58 20 PM

Screenshot 2024-06-13 at 5 59 42 PM

I think the stock version looks a little better because all items are left aligned (ours indents differently when the chevrons are present/missing). I also think the smaller chevrons look slightly better (but that's just cosmetic). docs.github.com use 16x16 icons which look pretty good.

@philwebb
Copy link
Contributor

I'm a massive idiot and was looking at an old version of the code 🤕

If I use the actual current code things look good!

Screenshot 2024-06-14 at 4 34 18 AM

@oodamien oodamien merged commit 114327f into spring-io:main Jun 14, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sidebar pages/not page not distinguishable
2 participants