Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feat) add standalone browser version (iife) #8

Merged
merged 2 commits into from
Jan 24, 2019
Merged

(feat) add standalone browser version (iife) #8

merged 2 commits into from
Jan 24, 2019

Conversation

bobaaaaa
Copy link
Contributor

What

  • create a new ES5 transpiled version for browsers only (dist/sticky-observer.js)
  • includes the namespace sticky (only for the browser version) 😞
  • add a simple demo index.html

Fixes #7

@codecov
Copy link

codecov bot commented Jan 24, 2019

Codecov Report

Merging #8 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master       #8   +/-   ##
=======================================
  Coverage   96.56%   96.56%           
=======================================
  Files           7        7           
  Lines         233      233           
  Branches       33       33           
=======================================
  Hits          225      225           
  Misses          1        1           
  Partials        7        7

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65d1ee7...7b1a6d5. Read the comment docs.

@bobaaaaa bobaaaaa merged commit 206bf83 into spring-media:master Jan 24, 2019
@bobaaaaa bobaaaaa deleted the feature/umd branch January 24, 2019 08:34
@bavarianbytes
Copy link

Was it your intention that there is no dist/sticky-observer.js?

@bobaaaaa
Copy link
Contributor Author

git clone git@github.com:spring-media/sticky-observer.git
cd sticky-observer
yarn install
yarn build
ls dist/

@bavarianbytes
Copy link

Thx, wouldn't it be a good idea to included an ES5 compiled version in the package, like most other packages do? Therefore users can use it via dependency tools like npm without any need do run certain build processes.

@cjies cjies mentioned this pull request Aug 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants